Neovim theme looks different in iTerm2 and Warp

[bookercodes]

Discord username (optional)

No response

Describe the bug

My Neovim theme looks different (especially the pink) in Warp compare to Iterm2.

To Reproduce

Steps to reproduce:

1. Install https://github.com/wadackel/vim-dogrun
2. Set colorscheme dogrun and set termguicolors
3. Open a JavaScript file in iTerm and in Warp
4. Compare

Expected behaviour

I expect Hyper to look like iTerm (which looks like the screenshots of the theme)

Screenshots

Operating System

MacOS

OS Version

12.0.1

Additional context

Hi team 👋! I wouldn't expect someone to go to the trouble of installing a Vim theme here! Just wondering what the likely suspect is?

[bijancn]

I can confirm that colors are very much off. I suspect 256 color support is not there

[wkei]

same issue with ayu theme

Hyper vs Warp

[xcpky]

I have the same issue

[elviskahoro]

Does it still look off for yall?

[bijancn]

Seems to be fixed! (Warp is left, iterm2 is right. First 16 colors are user definable so they don't count)

[xcpky]

No, I am using v0.2022.07.04.09.08.stable_02 and I still have the same issue

[Brendonovich]

Yeah, I'm not sure that this is fixed yet. iTerm2 and Alacritty both look normal, Warp looks desaturated. Could it be related to lack of P3 gamut support?

[jordanbrauer]

Does it still look off for yall?

Unfortunately, yes @elviskahoro 😞 .. It seems that 256 is supported & consistent, but anything outside of those colours (using hexcodes) is washed/desaturated or simply does not render :(

At this point I would say that this is the biggest hurdle for me in adopting Warp as my terminal. You guys have done an excellent job at the UX (just needs support for vim mode from .inputrc now 😝!).

Comparisons

Warp (left) and Kitty (right) both running Neovim and the same colour scheme.

• note the grey text is not working in Warp (directory names, line numbers, text, file info, etc.)
• the dark green colour is not correct in Warp (branch name along the bottom, func keyword..)

[elviskahoro]

Going to CC @vorporeal and @gagata

[bfulop]

It looks like Warp has no issues displaying all the colors, see the left side of my screenshot. I'm using a color highlighter plugin inside Neovim, and all the colors are properly showing.

It somehow then overrides the theme colors with some random ones. Maybe it's trying to apply it's own color highlighting over Neovim (treesitter)?
It looks like (vim) background colors are shown OK (e.g. the blue background under Strings), but when they are set for the foreground, they are being overwritten.

Same code in Kitty:

It's a pity because in my own, subjective tests, Warp is the fastest among all the terminal emulators, even Neovim some GUIs! 🚀 👏

To test, I used a Neovim smooth scrolling plugin, on a 4K screen, created vertical window splits inside Neovim and tested (smooth) scrolling in the middle one. It was only in Warp where the scrolling stayed smooth no matter how many splits I created. Kitty, Alacritty, Fvim were all slower to begin with (one split, Fvim) or started to drop frames when adding new (vertical) splits (e.g. Kitty).

[vorporeal]

@bfulop Thanks for the detailed comment! We've identified the source of the problem and have a fix in the works; we're aiming to get it out in next week's release. :)

[elviskahoro]

Sharing this across various color related issues. The team fixed one of the core issues with colors and there's a new toggle under Settings > Appearance that let's you configure whether to enforce a minimum contrast (one of the issues). Please check if you're still having color issues again and test tweaking the toggle:

[bfulop]

Working great for me! Thank you for the fix!