Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt in one line / Cursor in the same line with the prompt #2304

Open
AMATEURTOSS opened this issue Dec 6, 2022 · 66 comments
Open

Prompt in one line / Cursor in the same line with the prompt #2304

AMATEURTOSS opened this issue Dec 6, 2022 · 66 comments
Labels
Feature requests Feature Requests

Comments

@AMATEURTOSS
Copy link

AMATEURTOSS commented Dec 6, 2022

is there any option to make prompt in one line?

current behavior

~/some/location
something command -option

one line prompt

~/some/location > something command -option

How important is this feature to you?

1 (Not too important)

@AMATEURTOSS AMATEURTOSS added the Feature requests Feature Requests label Dec 6, 2022
@unbreakabl3
Copy link

+1 for the same feature

@dannyneira
Copy link
Member

dannyneira commented Dec 6, 2022

Thanks for this feature request! Please 👍 and subscribe to this request as it helps us gauge interest. We will post any updates here.

One of the main features of Warp is its multi-line input editor which works like an IDE or modern text editor.
This allows you to write/modify commands with the help of a keyboard/mouse, Autocompletion, A.I. Command Search, etc before you run it.
The prompt is in its own separate line because if needs to be rendered/updated before every command is run, so the two are separate, unlike with traditional terminals where the prompt and input are on the same line (not as feature-rich)
CleanShot 2022-12-06 at 09 35 34

@B0Y3R
Copy link

B0Y3R commented Jan 5, 2023

+1 this would be great to have

@bryanlatten
Copy link

@dannyneira totally understood - and we thank you for an excellent terminal++!
my issue, a blinking cursor on a new line in any other terminal (which i'll still have to use elsewhere) means there is a long-running process happening. Hard to shake that feeling! 🤞 there's a cheap and easy way to bring the standard behavior back.

@dannyneira
Copy link
Member

dannyneira commented Jan 9, 2023

@bryanlatten We've released the option to disable the blinking cursor, see more on this here:
https://docs.warp.dev/appearance/text-fonts-cursor#cursor
Hope that helps!

@Noamko
Copy link

Noamko commented Jan 18, 2023

Thanks for this feature request! Please 👍 and subscribe to this request as it helps us gauge interest. We will post any updates here.

One of the main features of Warp is its multi-line input editor which works like an IDE or modern text editor. This allows you to write/modify commands with the help of a keyboard/mouse, Autocompletion, A.I. Command Search, etc before you run it. The prompt is in its own separate line because if needs to be rendered/updated before every command is run, so the two are separate, unlike with traditional terminals where the prompt and input are on the same line (not as feature-rich) CleanShot 2022-12-06 at 09 35 34

With a busy terminal - inputs, prompts and headers gets combined and it gets really messy and confusing,
so switching to one-line will be very useful in this case.

Also for people trying to switch to warp from iTerm (90% of people most likely) its kinda hard to get used to the multiline editor.

IDEA: Default will be one-line editor and when the user hits cmd+enter or shift+enter it switches to the multiline editor with the input that was already typed beforehand.
or Default will be the multiline with an option to swap the default in preferences.

Please let me know what you think.
Thanks for the great terminal! :)

@bryanlatten
Copy link

^^ love the idea of a toggle. feature-rich vs. not feature-rich

@tmlane
Copy link

tmlane commented Jan 26, 2023

+1 would be nice to have. Make or break from switching over

@GreenPatrick2
Copy link

+1

@reimund
Copy link

reimund commented Mar 9, 2023

+1

I've lost valuable time by committing stuff to the wrong branch simply because I don't read the line above as much as the line with the input. This feature is very dear to me. I do not use multi-line that much (yet?).

@MarkoTurunen
Copy link

MarkoTurunen commented Mar 30, 2023

+1, I tried to find option to keep prompt on one line and that is not possible??

@NIVJAIN
Copy link

NIVJAIN commented Apr 5, 2023

+1, important for me, this is one of the main reason sometimes i switch to iterm.

@code-yeongyu
Copy link

+1, Very annoying for me to use warp.

@cedricpuddy
Copy link

+1. While the "2 line prompt" and "multi-line" feature is interesting and has it's place, 95% of my terminal use happens on one line, and compromises required to support this "convienient 5% of the time" are really big, for me at least.

IMHO, not having a prompt followed by a cursor has always meant "the computer is not ready for input". I look the left of the cursor to check my context always (am I in the right directory/context? the right user? the right host? ... Yes? OK, start typing. Done typing... check again, hit enter.).

This matters very much when you spend a lot of time in root/priveledged contexts. This multiline thing breaks that basic understanding, which makes it harder for me to use as a daily driver terminal.

Making it harder to use as a daily driver means that it's harder to learn and benefit from the code blocks, multiline editing, ai suggestions, and so on - simply because you are less likely to be in Warp when the situation comes up, so you solve it the way you always have in the past.

It's especially confusing to me that it still functions like a single-line terminal by default -- you type a command, you hit enter, it runs -- so that "multi-line" stuff that people keep talking about still requires active learning -- if you are really trying to sell the world on multiline editing, why isn't it SHIFT-ENTER to actually run the command(s) you've just typed, and enter to just move to the next line?

I also HATE that so much vertical space is taken up by all this prompt/context stuff -- most folks I know have a short prompt with just key context. If having 40+ characters of Context Stuff is darn important, why not just the current context "float" above the current prompt, and then STICK it in the scroll-back log only WHEN IT CHANGES -- that way, when you scroll back, you could have a clean lists of commands, and only have the extra junk when contexts change? (I grew up on 25 line terminals though, and I recognize that I might be more jealous of that vertical space than others!)

I would LOVE this thing 1000x more if, as @Noamko suggested above, it could be 1 line by default, and cmd-enter or shift-enter or something to bump it into multiline mode on the fly.

You guys have written a truly fast nifty terminal, and I love it, but I can't daily drive it :( Apple Terminal remains my daily driver because this 2-line prompt thing is such constant sandpaper on my brain.

Hope that's helpful, and regardless, mad props to all y'all for doing some mighty fine software engineering. It's been a long time since anything this exciting has happened in the terminal space.

@SebiBasti
Copy link

I just started using warp and this is super confusing and I would like to have it all in one line.

@zkl94
Copy link

zkl94 commented Apr 10, 2023

Having prompt in two lines is very confusing as I have been using one line prompt all my life. Should acknowledge that people have different habits and give users different options.

@MarkoTurunen
Copy link

I’ve been using warp several months and now switching back to iterm2 because of this. I cannot get used to two line prompt, it still feels weird. Warp is great product, but I cannot believe that this kind of design flaw still exists. I’ll be tagged to this CR and hopefully it gets fixed/implemented so I can switch back. Thanks!

@umutbasal
Copy link

+1 and
How important is this feature to you?
VERY IMPORTANT

@JINWOO-J
Copy link

+1, I love to this feature

@usatenko
Copy link

yes, it should have capabilities of a normal terminal
also, +1

@Pyrathar
Copy link

Pyrathar commented Jun 6, 2023

This is the only thing blocking me from using it everyday, it kinda throws me off thats not in the same line

@usatenko
Copy link

usatenko commented Jun 6, 2023

it would be good if it would have the option to use it as a regular terminal without any additional beautifializers, just standard terminal with one key dropdown option enabled, it would be veeeery convenient

@MarkoTurunen
Copy link

This issue been here since Dec 2022, so better look at other options. Luckily there are other options.

@Bryant-Yang
Copy link

p10k has this config, will Warp have this option when p10k supported?
image

@dannyneira
Copy link
Member

We don't currently support P10K, but we're working on it. Because of how we use the prompt_command in Warp and how the input editor works like an IDE, the prompt and input will most likely be separate in Warp for the time being. This allows for users to have custom prompts and retain the modern input experience that we hope helps developers be more productive with Warp.

Please add a :+1: to the original post at the top to signal that you want this feature (we take this factor into account when deciding what to work on next), and then hit the subscribe button if you'd like to be notified.

@NIVJAIN
Copy link

NIVJAIN commented Jun 24, 2023

+1 was looking for this since day 1 for warp.

@aibangjuxin
Copy link

+1

@13zebras
Copy link

I'm glad the approach you are taking is supporting 1 line and 2 line. I'm firmly in the 2 line camp. I used 1 line for years, but 2 lines keeps everything much clearer to me. I have more context, etc., by using a 2 line starship prompt that shows shell, user, cwd, git, and more. 2 lines also gives more separation between commands vs the often crowded single line, no vertical spacing terminals I had used in the past.

I'm not trying to dismiss the comments and preferences of others. Rather, I'm voicing support for both/and vs either/or. For those of us with older eyes and weak vision, more space and ability to configure to our needs is a HUGE plus.

@Alonski
Copy link

Alonski commented Dec 26, 2023

Chiming in to say that the issue with newline after PROMPT is only when using your Shell prompt (Settings -> Appearance -> Prompt)
Going back to the Warp prompt "fixes" the issue.

If the Warp prompt allowed more customization I would be happy to use that over my custom Prompt.

This is my current custom Prompt:

autoload -Uz vcs_info
precmd_vcs_info() { vcs_info }
precmd_functions+=( precmd_vcs_info )
setopt prompt_subst
RPROMPT='%F{208}${vcs_info_msg_0_}%f'
zstyle ':vcs_info:git:*' formats '%b'
PROMPT='%F{208}%4~%f %F{255}->%f '

The important thing for me here is the use of RPROMPT to keep Git info on the right and not take up too much left real estate as well as the folder path being truncated to 4 levels.

Thanks for Warp!

@ncushing
Copy link

Chiming in to say that the issue with newline after PROMPT is only when using your Shell prompt (Settings -> Appearance -> Prompt) Going back to the Warp prompt "fixes" the issue.

If the Warp prompt allowed more customization I would be happy to use that over my custom Prompt.

This is my current custom Prompt:

autoload -Uz vcs_info
precmd_vcs_info() { vcs_info }
precmd_functions+=( precmd_vcs_info )
setopt prompt_subst
RPROMPT='%F{208}${vcs_info_msg_0_}%f'
zstyle ':vcs_info:git:*' formats '%b'
PROMPT='%F{208}%4~%f %F{255}->%f '

The important thing for me here is the use of RPROMPT to keep Git info on the right and not take up too much left real estate as well as the folder path being truncated to 4 levels.

Thanks for Warp!

+1 for me on this as well. I have a prompt that shows the information I care about in the format I like, and without the extra newlines, it'd work perfect for Warp as well.

@Advait-M
Copy link
Member

Advait-M commented Dec 26, 2023

Chiming in to say that the issue with newline after PROMPT is only when using your Shell prompt (Settings -> Appearance -> Prompt) Going back to the Warp prompt "fixes" the issue.

If the Warp prompt allowed more customization I would be happy to use that over my custom Prompt.

This is my current custom Prompt:

autoload -Uz vcs_info
precmd_vcs_info() { vcs_info }
precmd_functions+=( precmd_vcs_info )
setopt prompt_subst
RPROMPT='%F{208}${vcs_info_msg_0_}%f'
zstyle ':vcs_info:git:*' formats '%b'
PROMPT='%F{208}%4~%f %F{255}->%f '

The important thing for me here is the use of RPROMPT to keep Git info on the right and not take up too much left real estate as well as the folder path being truncated to 4 levels.

Thanks for Warp!

Hey @Alonski thanks for the context and suggestion to allow Warp's built-in prompt to have an rprompt as well. Definitely agree this would be useful - we've actually had this idea brought up internally too, for the Git case exactly haha!

I've opened #4001 to track this as a feature request, since it's a bit separate from this issue. Please 👍 there to indicate interest and feel free to add info/details on the request thread so we can prioritize accordingly!

@fujohnwang
Copy link

+1, current behavior is annoying.

@jordantshaw
Copy link

Any ETA on this? Great product, but annoying extra lines when using starship keeping me from switching over to warp full time.

@Advait-M
Copy link
Member

Any ETA on this? Great product, but annoying extra lines when using starship keeping me from switching over to warp full time.

Hey there 👋 ! Thanks for the feedback. No concrete ETA for release, but I can say that I'm continuing to actively work on getting this over the finish line.

If folks are interested: I won't dive too deep into the technical complexity here (I might consider a blog post later if there's enough interest 👀 ) - but TL;DR is that this has led to a much bigger refactor/reworking of underlying core terminal rendering logic than initially expected, largely due to 2 points:

  • Properly interweaving a "traditional prompt grid" with Warp's modern input editor presents some unique UI challenges with respect to aspects such as soft-wrapping text, handling scrolling, selections, multi-line lprompts and rprompts.
  • Presenting a "traditional" layout in finished blocks (i.e. past commands), where the prompt/command are "one entity" from a text layout/grid POV, but Warp is still able to differentiate between the two concepts for many other dependencies in the application, e.g. the "Copy Command" action, also presents numerous unique challenges across the 3 shells we support (zsh, bash & fish) and any prompt plugins we support e.g. powerlevel10k.

This issue in particular is something where we want very high confidence in no regressions before release as well, since it directly affects the core terminal experience and any dependencies.

Thanks to everyone for indicating their interest in this feature and giving their thoughts (keep them coming as relevant!) ❤️ . I'll be sure to ping this thread 🔔 when we do include this into a new Warp release (especially for folks who currently aren't able to use Warp due to this)!

@TimAnthonyAlexander
Copy link

+1

1 similar comment
@haristhohir
Copy link

+1

@yatanasov
Copy link

+1

1 similar comment
@martylukyy
Copy link

+1

@sngtn
Copy link

sngtn commented Feb 23, 2024

+1

@earmellin
Copy link

  • 1

@KoderFPV
Copy link

+1

@luizeboli
Copy link

luizeboli commented Feb 23, 2024

Hey everyone, pls stop spamming +1, you are annoying almost 50 people with useless notifications and just flooding the issue. Reacting to the main post should be enough.

The team already said they are working on this, let's be patient 🙏🏽

@Advait-M
Copy link
Member

Thanks! Yep, we're still working on this (working through supporting each of the shells + cases like subshells and SSH currently) and just a note to add onto what @luizeboli said: if you'd just like to subscribe to the issue for notifications, you can do that without commenting by using the sidebar in GitHub (on the right) - would recommend to follow along! See screenshot:

image

@jimcornmell
Copy link

+1. Please make the prompt 1 line.... looks rubbish over 2 lines and takes too much room

@Guillermogsjc
Copy link

Guillermogsjc commented Feb 25, 2024

please do this feature, warp is awesome but this non-configurable and opposed to terminal standards appearance makes quite confusing to work with it

@Guillermogsjc
Copy link

I just do not understand the downvotes on the positive feedback of this feature.

Standard terminals have prompts in one line and users are used to this. It is everywhere, on console on cloud, on every other cmd prompts.

The only needed thing is to set this "one prompt line" as a configurable toggle in appearance, as it is with many other useful customizable things already. This application is great, and this would make it even more great :)

Which is the problem of having this point also as configurable?

@AlecRust
Copy link

The downvotes are because spamming this issue with comments is unnecessary and notifies everyone.

This was clearly stated in #2304 (comment). People ignored that, and continued adding "+1" comments 🤦

FWIW I would lock this issue, it's very clear what the request is.

@warpdotdev warpdotdev locked and limited conversation to collaborators Feb 26, 2024
@Advait-M
Copy link
Member

Advait-M commented Feb 26, 2024

Yep, let me lock this thread until we can post further updates on releasing this feature 🔒 ! Note the most recent update is here (briefly outlines why this is technically challenging in the context of Warp - essentially constitutes a rework of core Warp logic).

Thanks for all the feedback folks - if there's other different prompt-related issues, please open a new issue (but if it's pertaining to this topic, we're on it!)

@dannyneira dannyneira changed the title Prompt in one line Prompt in one line / Cursor in the same line with the prompt Mar 6, 2024
@dannyneira dannyneira pinned this issue Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature requests Feature Requests
Projects
None yet
Development

No branches or pull requests