Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt in one line / Cursor in the same line with the prompt #2304

Open
AMATEURTOSS opened this issue Dec 6, 2022 · 96 comments
Open

Prompt in one line / Cursor in the same line with the prompt #2304

AMATEURTOSS opened this issue Dec 6, 2022 · 96 comments
Labels
Feature requests Feature Requests

Comments

@AMATEURTOSS
Copy link

AMATEURTOSS commented Dec 6, 2022

[WARP] Note to all users opening this issue:

  • Latest update: we're slowly rolling this out to folks, to ensure stability! Please see the comment here!
  • Please see prior update from Warp here. This is actively being worked on.

is there any option to make prompt in one line?

current behavior

~/some/location
something command -option

one line prompt

~/some/location > something command -option

How important is this feature to you?

1 (Not too important)

@AMATEURTOSS AMATEURTOSS added the Feature requests Feature Requests label Dec 6, 2022
@unbreakabl3
Copy link

+1 for the same feature

@dannyneira
Copy link
Member

dannyneira commented Dec 6, 2022

Thanks for this feature request! Please 👍 and subscribe to this request as it helps us gauge interest. We will post any updates here.

One of the main features of Warp is its multi-line input editor which works like an IDE or modern text editor.
This allows you to write/modify commands with the help of a keyboard/mouse, Autocompletion, A.I. Command Search, etc before you run it.

CleanShot 2022-12-06 at 09 35 34

@B0Y3R
Copy link

B0Y3R commented Jan 5, 2023

+1 this would be great to have

@bryanlatten
Copy link

@dannyneira totally understood - and we thank you for an excellent terminal++!
my issue, a blinking cursor on a new line in any other terminal (which i'll still have to use elsewhere) means there is a long-running process happening. Hard to shake that feeling! 🤞 there's a cheap and easy way to bring the standard behavior back.

@dannyneira
Copy link
Member

dannyneira commented Jan 9, 2023

@bryanlatten We've released the option to disable the blinking cursor, see more on this here:
https://docs.warp.dev/appearance/text-fonts-cursor#cursor
Hope that helps!

@Noamko
Copy link

Noamko commented Jan 18, 2023

Thanks for this feature request! Please 👍 and subscribe to this request as it helps us gauge interest. We will post any updates here.

One of the main features of Warp is its multi-line input editor which works like an IDE or modern text editor. This allows you to write/modify commands with the help of a keyboard/mouse, Autocompletion, A.I. Command Search, etc before you run it. The prompt is in its own separate line because if needs to be rendered/updated before every command is run, so the two are separate, unlike with traditional terminals where the prompt and input are on the same line (not as feature-rich) CleanShot 2022-12-06 at 09 35 34

With a busy terminal - inputs, prompts and headers gets combined and it gets really messy and confusing,
so switching to one-line will be very useful in this case.

Also for people trying to switch to warp from iTerm (90% of people most likely) its kinda hard to get used to the multiline editor.

IDEA: Default will be one-line editor and when the user hits cmd+enter or shift+enter it switches to the multiline editor with the input that was already typed beforehand.
or Default will be the multiline with an option to swap the default in preferences.

Please let me know what you think.
Thanks for the great terminal! :)

@bryanlatten
Copy link

^^ love the idea of a toggle. feature-rich vs. not feature-rich

@tmlane
Copy link

tmlane commented Jan 26, 2023

+1 would be nice to have. Make or break from switching over

@GreenPatrick2
Copy link

+1

@reimund
Copy link

reimund commented Mar 9, 2023

+1

I've lost valuable time by committing stuff to the wrong branch simply because I don't read the line above as much as the line with the input. This feature is very dear to me. I do not use multi-line that much (yet?).

@MarkoTurunen
Copy link

MarkoTurunen commented Mar 30, 2023

+1, I tried to find option to keep prompt on one line and that is not possible??

@NIVJAIN
Copy link

NIVJAIN commented Apr 5, 2023

+1, important for me, this is one of the main reason sometimes i switch to iterm.

@code-yeongyu
Copy link

+1, Very annoying for me to use warp.

@cedricpuddy
Copy link

+1. While the "2 line prompt" and "multi-line" feature is interesting and has it's place, 95% of my terminal use happens on one line, and compromises required to support this "convienient 5% of the time" are really big, for me at least.

IMHO, not having a prompt followed by a cursor has always meant "the computer is not ready for input". I look the left of the cursor to check my context always (am I in the right directory/context? the right user? the right host? ... Yes? OK, start typing. Done typing... check again, hit enter.).

This matters very much when you spend a lot of time in root/priveledged contexts. This multiline thing breaks that basic understanding, which makes it harder for me to use as a daily driver terminal.

Making it harder to use as a daily driver means that it's harder to learn and benefit from the code blocks, multiline editing, ai suggestions, and so on - simply because you are less likely to be in Warp when the situation comes up, so you solve it the way you always have in the past.

It's especially confusing to me that it still functions like a single-line terminal by default -- you type a command, you hit enter, it runs -- so that "multi-line" stuff that people keep talking about still requires active learning -- if you are really trying to sell the world on multiline editing, why isn't it SHIFT-ENTER to actually run the command(s) you've just typed, and enter to just move to the next line?

I also HATE that so much vertical space is taken up by all this prompt/context stuff -- most folks I know have a short prompt with just key context. If having 40+ characters of Context Stuff is darn important, why not just the current context "float" above the current prompt, and then STICK it in the scroll-back log only WHEN IT CHANGES -- that way, when you scroll back, you could have a clean lists of commands, and only have the extra junk when contexts change? (I grew up on 25 line terminals though, and I recognize that I might be more jealous of that vertical space than others!)

I would LOVE this thing 1000x more if, as @Noamko suggested above, it could be 1 line by default, and cmd-enter or shift-enter or something to bump it into multiline mode on the fly.

You guys have written a truly fast nifty terminal, and I love it, but I can't daily drive it :( Apple Terminal remains my daily driver because this 2-line prompt thing is such constant sandpaper on my brain.

Hope that's helpful, and regardless, mad props to all y'all for doing some mighty fine software engineering. It's been a long time since anything this exciting has happened in the terminal space.

@SebiBasti
Copy link

I just started using warp and this is super confusing and I would like to have it all in one line.

@zkl94
Copy link

zkl94 commented Apr 10, 2023

Having prompt in two lines is very confusing as I have been using one line prompt all my life. Should acknowledge that people have different habits and give users different options.

@MarkoTurunen
Copy link

I’ve been using warp several months and now switching back to iterm2 because of this. I cannot get used to two line prompt, it still feels weird. Warp is great product, but I cannot believe that this kind of design flaw still exists. I’ll be tagged to this CR and hopefully it gets fixed/implemented so I can switch back. Thanks!

@umutbasal
Copy link

+1 and
How important is this feature to you?
VERY IMPORTANT

@JINWOO-J
Copy link

+1, I love to this feature

@usatenko
Copy link

yes, it should have capabilities of a normal terminal
also, +1

@Pyrathar
Copy link

Pyrathar commented Jun 6, 2023

This is the only thing blocking me from using it everyday, it kinda throws me off thats not in the same line

@usatenko
Copy link

usatenko commented Jun 6, 2023

it would be good if it would have the option to use it as a regular terminal without any additional beautifializers, just standard terminal with one key dropdown option enabled, it would be veeeery convenient

@MarkoTurunen
Copy link

This issue been here since Dec 2022, so better look at other options. Luckily there are other options.

@Bryant-Yang
Copy link

p10k has this config, will Warp have this option when p10k supported?
image

@dannyneira
Copy link
Member

dannyneira commented Jun 12, 2023

We don't currently support P10K, but we're working on it.

Please add a :+1: to the original post at the top to signal that you want this feature (we take this factor into account when deciding what to work on next), and then hit the subscribe button if you'd like to be notified.

@NIVJAIN
Copy link

NIVJAIN commented Jun 24, 2023

+1 was looking for this since day 1 for warp.

@aibangjuxin
Copy link

+1

@ashebanow
Copy link

ashebanow commented Jun 21, 2024 via email

@daUnknownCoder
Copy link

Hey @Advait-M, can u tell me where's the upvote feature? I guess I forgot it's location, if anyone finds it, press it 1000 times for me

@Advait-M
Copy link
Member

Advait-M commented Jun 21, 2024

YAY!! Where can this setting be enabled?

@mboeker If you're in the 10% roll-out, you'll see it pop up in the Edit Prompt modal for Warp prompt (Settings > Appearance > Prompt or Command Palette)! For PS1 (shell prompt), it'll automatically be converted to same line prompt (since we want to respect your shell prompt exactly!).

image

Hey @Advait-M, can u tell me where's the upvote feature? I guess I forgot it's location, if anyone finds it, press it 1000 times for me

@daUnknownCoder haha - it's right here (top of this thread - 👍 ):
image

But yep, we've already noted this is very important for users hence we're working on launching this fully 😄 !

@mboeker
Copy link

mboeker commented Jun 21, 2024 via email

@damongolding
Copy link

Awesome thanks!

I'm not in the 10% so I shall have to begrudgingly wait

@daUnknownCoder
Copy link

daUnknownCoder commented Jun 21, 2024

guess what, @Advait-M, find happiness in this photo:

image

@Advait-M
Copy link
Member

guess what, @Advait-M, find happiness in this photo:

Haha - to clarify explicitly: everyone is expected to receive this version update. However, only 10% of folks (once on this version) will be included in the experimental roll-out of same line prompt currently! So it may be the case that you update and you don't see SLP yet!

@daUnknownCoder
Copy link

okay so i updated and idk how to migrate to the build u r on? i dont know how to be in the 10%? @Advait-M

@damongolding
Copy link

damongolding commented Jun 21, 2024 via email

@Advait-M
Copy link
Member

okay so i updated and idk how to migrate to the build u r on? i dont know how to be in the 10%? @Advait-M

It's purely random currently i.e. you can't voluntarily migrate unfortunately. This is for stability reasons, as noted above, we want to ensure all of Warp's functionality is good to go before we do a larger roll-out. I'll update this thread when we do decide to do a 100% roll-out (my current best guess is in the next ~month but there's various factors at play here).

I appreciate the excitement from folks and I know this has been something all of you have been waiting for (as have I 😄 )!!

@mfittko
Copy link

mfittko commented Jun 21, 2024

damn, guess I'm in the other 90% - isn't there a way to "roll the dice" again? ;) looking forward to its public release!

@daUnknownCoder
Copy link

damn, guess I'm in the other 90% - isn't there a way to "roll the dice" again? ;) looking forward to its public release!

you can freely roll the dice in about a month from now, until then i'll be shipping binks brew in your boat

@mboeker
Copy link

mboeker commented Jun 21, 2024

I tried downloading the installer a bunch of times from different regions on different systems, they were always the same byte count, so that doesn't seem to be the trick

@daUnknownCoder
Copy link

daUnknownCoder commented Jun 21, 2024

I tried downloading the installer a bunch of times from different regions on different systems, they were always the same byte count, so that doesn't seem to be the trick

you actually went that far? 💀
and yeah i gave up thinking that i wasnt lucky, tho i was in their first 100 users private linux beta, i didnt get lucky this time...

and yeah @Advait-M, im not good at probability so i would like to ask on what basis do you get volunteers to get lucky? is it how much they use Warp terminal or Warp AI or some other terms? Like this luck might get passed to peeps who dont even open warp... just asking coz if its random there must be an algorithm for guessing ig

@daUnknownCoder
Copy link

daUnknownCoder commented Jun 21, 2024

@Advait-M:

My own Warp session after updating to the new build 👀 :

is the prompt fish+tide? or zsh+powerlevel10k? curious (if it is the former -> 2 birds with one stone, if the latter -> 0 birds with 2 stones)
My own Warp session after updating to the new build 👀 :

@Advait-M
Copy link
Member

and yeah @Advait-M, im not good at probability so i would like to ask on what basis do you get volunteers to get lucky? is it how much they use Warp terminal or Warp AI or some other terms? Like this luck might get passed to peeps who dont even open warp... just asking coz if its random there must be an algorithm for guessing ig

Haha - completely randomized. No particular signals being used.

@Advait-M:

My own Warp session after updating to the new build 👀 :

is the prompt fish+tide? or zsh+powerlevel10k? curious (if it is the former -> 2 birds with one stone, if the latter -> 0 birds with 2 stones) My own Warp session after updating to the new build 👀 :

This one was zsh + powerlevel10k! But yep, same line prompt will be supported across zsh, bash and fish + the goal is all prompt plugins. This is part of the reason for the roll-out - there's a massive variety of shell + prompt plugin combinations that we'd like to confirm are all looking good!

@daUnknownCoder
Copy link

tide + fish? #3358?

@pyxelr
Copy link

pyxelr commented Jun 21, 2024

Finally ❤️!

I confirm that all is fine so far with my Starship prompt in zsh:

warp

By the way, here is the snippet I saw in Warp after the update for putting the newline back in PS1:

echo 'PROMPT="${PROMPT}"$'\''\\n'\''' >> ~/.zshrc

@daUnknownCoder
Copy link

Hey @Advait-M, ig this is solved so what about pushing this to main and focus on #239?

@daUnknownCoder
Copy link

If anyone knows Tho and I didn't want to open a ticket for this, if I type "hello" it won't go to agent mode, it will say unknown command

@youvegotmoxie
Copy link

@daUnknownCoder what does this have to do with the single line prompt?

@daUnknownCoder
Copy link

daUnknownCoder commented Jun 24, 2024

@daUnknownCoder what does this have to do with the single line prompt?

Yeah ik that that's why I said:
If anyone knows Tho and I didn't want to open a ticket for this

I thought this was a very petty thing for a ticket to be issued

@Advait-M
Copy link
Member

tide + fish? #3358?

Ooh, I think that this should be fixed as a side-effect! However, I'm not super knowledgeable with all of tide's config. I just tried it out myself and it looks good to me (a lot better than previous iteration of Warp!)

Screenshot (w/ the same line prompt rollout):
image

I'd love for some active tide + fish users to verify this - we can definitely do this when we do ramp up to 100% rollout later 😄 . In any case, It should be a strict improvement over the current experience!

For context, we've changed the underlying mechanisms with which we pass prompt bytes - which should result in better plugin support across the board! This rework is similar to what we did to support p10k in Zsh (however, I've done this for Bash + fish now!) 🎉

@Advait-M
Copy link
Member

Hey @Advait-M, ig this is solved so what about pushing this to main and focus on #239?

We actually have prototyped ligatures support, however, there's severe performance regressions with this prototype. I believe the plan is to return to this at some point, however, no ETA on this and we're not sure when we'll be able to prioritize this (there's a few technical challenges to figure out here!).

Note that I actually did implement slightly better Unicode support as a part of same line prompt! See #4191 (comment) for details - we added support for correct emoji rendering with emoji presentation selectors 😄 (this unblocks Starship on fish).

@Advait-M
Copy link
Member

Finally ❤️!

I confirm that all is fine so far with my Starship prompt in zsh:

warp

By the way, here is the snippet I saw in Warp after the update for putting the newline back in PS1:

echo 'PROMPT="${PROMPT}"$'\''\\n'\''' >> ~/.zshrc

AWESOME 🎉!! Love to hear it and thanks for the positive feedback 😄

@Advait-M
Copy link
Member

If anyone knows Tho and I didn't want to open a ticket for this, if I type "hello" it won't go to agent mode, it will say unknown command

Ah, this sounds like it could be a bug with Agent Mode input autodetection 👀 ? Yeah, could you please open a new GitHub issue for this and we can help you there! Thanks! 😄

@warpdotdev warpdotdev deleted a comment from pkelaita Jun 30, 2024
@Advait-M
Copy link
Member

Hey folks - please keep it professional. You can unsubscribe to this issue if you'd like via GitHub UI.

Otherwise, I'm hoping to keep this issue unlocked for any feedback!

As noted, I'll post an update when we roll out further - we're working through polishing some stuff up! 😀

@daUnknownCoder
Copy link

hey @Advait-M, the next message of yours should be: Rolling Out to 20% of the folks, i hope this happens soon 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature requests Feature Requests
Projects
None yet
Development

No branches or pull requests