Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not showing my PS1 correctly #4054

Closed
tpak opened this issue Jan 10, 2024 · 7 comments
Closed

not showing my PS1 correctly #4054

tpak opened this issue Jan 10, 2024 · 7 comments
Labels
Bugs Bugs, Hangs, Crash, and Freezes

Comments

@tpak
Copy link

tpak commented Jan 10, 2024

Discord username (optional)

No response

Describe the bug

I use a combo of zim and powerlevel10k and my existing PS1 prompt is not honored correctly
My existing PS1:
Screenshot 2024-01-10 at 11 19 54 AM

What Warp setup shows me:
Screenshot 2024-01-10 at 11 20 13 AM

To reproduce

here are my .zimrc and .p10k.zsh
p10k.zsh.txt
zimrc.txt

Expected behavior

prompt and icons from the supported and recommended font set for p10k should display correctly

Screenshots

Added them above.

Operating system

MacOS

Operating system and version

Sonoma 14.2.1

Shell Version

zsh 5.9 (arm-apple-darwin21.3.0)

Current Warp version

v0.2024.01.02.08.02.stable_02

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

n/a this is day 1

Additional context

I looked in the FAQ and see the support levels for p10k and that there are some issues, it is not clear to me if this is one of them or not

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

@tpak tpak added the Bugs Bugs, Hangs, Crash, and Freezes label Jan 10, 2024
@tpak
Copy link
Author

tpak commented Jan 10, 2024

also, FYI, restarting Warp after the initial config makes no difference

@dannyneira
Copy link
Member

dannyneira commented Jan 10, 2024

hey @tpak From your description and images, it appears the issue is that you're not seeing the input in the same line as the prompt. This is a known issue, since Warp currently renders the prompt and the input into separate UI elements. We already have a request tracking this over at #2304 and we're actively working on it. We'll post any updates there, so stay tuned!

Closing this as a duplicate.

@dannyneira
Copy link
Member

Duplicate of #2304

@dannyneira dannyneira marked this as a duplicate of #2304 Jan 10, 2024
@dannyneira dannyneira closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
@tpak
Copy link
Author

tpak commented Jan 10, 2024

@dannyneira I think I did not describe it well. If you look at my current iTerm2 / p10k prompt, it is in fact a 2 line prompt and Warp is providing me a 2 line prompt (with the same problem as in #2304) but it is also not displaying it correctly as configured in p10k. Note the missing icons.

I agree with many in #2304 with their reasons for single line prompts although I use a 2 line. Warp has turned my 2 line into 3 line and additionally does not display the icons from the p10k suggested font set properly, which is an additional problem. I get some people might not like those icons but they convey a bunch of info to me at a glance.

@dannyneira I respectfully request you review and re-open this. Thanks.

here are a couple more comparison screenshots

iTerm2 respecting my p10k PS1:
Screenshot 2024-01-10 at 2 07 55 PM

Warp:
Screenshot 2024-01-10 at 2 08 01 PM

@dannyneira
Copy link
Member

@tpak Thanks for clearing that up. As far as I'm aware, a Nerd Font (with icons) should be set up in Warp's Settings > Appearance > Text first, then restart Warp to clear the font cache and try p10k again. That may be the issue you're having with the lack of icons in your prompt. Please see the setup guide in our docs.

For example, see my p10k prompt in Warp with the default "Hack" font:

CleanShot 2024-01-11 at 09 34 22

Below is the same p10k prompt with the "Hack Nerd Font" (the one with the icons built-in):

CleanShot 2024-01-11 at 09 35 37

Please let me know if this helps.

@tpak
Copy link
Author

tpak commented Jan 11, 2024

@dannyneira, thanks for that - revisiting fonts I had accidentally selected Meslo LGS DZ not MesloLGS NF which is the nerd variant I have - I'll also have to check out the Hack variant

apologies for the extra work for you!

@dannyneira
Copy link
Member

dannyneira commented Jan 11, 2024

No worries, happy to help a fellow Coloradan :) hopefully, that'll get you up and running with the icons in your prompt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bugs, Hangs, Crash, and Freezes
Projects
None yet
Development

No branches or pull requests

2 participants