Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rows #556

Closed
ghost opened this issue Apr 8, 2013 · 3 comments
Closed

Move rows #556

ghost opened this issue Apr 8, 2013 · 3 comments
Labels
Guess: A day or more Status: Developed (ready for review) Type: Feature
Milestone
Mayflower

Comments

@ghost
Copy link

ghost commented Apr 8, 2013

Columns can be moved. What about rows?
@setthase
Copy link

setthase commented Apr 8, 2013

It is not available for now.

@warpech warpech added this to the Mayflower milestone May 4, 2014
@warpech warpech mentioned this issue May 4, 2014
Closed
Berus added a commit that referenced this issue Jun 16, 2014
@Berus
TODO:
7a761ef 
1) add move rows after scrolled
2) test. refs #556
Berus added a commit that referenced this issue Jun 16, 2014
@Berus
added move rows after scroll. refs #556
bcd71c0
Berus added a commit that referenced this issue Jun 16, 2014
@Berus
added tests. refs #556
28e1e32
Repository owner unassigned Berus Jul 10, 2014
Berus added a commit that referenced this issue Jul 17, 2014
@Berus @warpech
TODO:
88ff563 
1) add move rows after scrolled
2) test. refs #556
Berus added a commit that referenced this issue Jul 17, 2014
@Berus @warpech
added move rows after scroll. refs #556
15b6b11
Berus added a commit that referenced this issue Jul 17, 2014
@Berus @warpech
added tests. refs #556
eb91a97
warpech added a commit that referenced this issue Jul 17, 2014
@warpech
compatibility fix with current HOT (#556)
4353e65
@warpech
Copy link
Member

warpech commented Jul 17, 2014

@Berus, I have rebased the code to the current develop branch and pushed it under a new name feature/issue-556. Please use that branch for remaining fixes.

Branch feature/rowMove can be deleted.

Some comments:

  1. Three test cases manualRowMove do not pass. Could you take a look and fix it?
  2. When I click on the row move handle, the row gets selected. For a column this works OK (clicking on the column move handle does not select the column). This is related with Clicking on column move handler selects the column #1576 so please coordinate with @jansiegel

Berus added a commit that referenced this issue Jul 17, 2014
@Berus
* some improvements: render one move handler for all row headers (sim…
19455eb 
…ilar to row resize)

* bug fixing (selected row after clicked on move handler, not working persistent state after change row positions -> incorrect localStorage key manualRowPostions)

* fixed failure test

refs #556
Berus added a commit that referenced this issue Jul 17, 2014
@Berus
* merged column & row move demos. refs #556
fab68c0
@warpech
Copy link
Member

warpech commented Jul 22, 2014

Thanks! Merged to develop branch. Will ship in 0.11.0-beta2

@warpech warpech closed this as completed Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Guess: A day or more Status: Developed (ready for review) Type: Feature
Projects
None yet
Milestone
Mayflower
Development

No branches or pull requests
3 participants
@warpech @setthase @Berus