Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AreTomo2 compatibility #57

Merged
merged 13 commits into from
May 10, 2024
Merged

add AreTomo2 compatibility #57

merged 13 commits into from
May 10, 2024

Conversation

alisterburt
Copy link
Contributor

@alisterburt alisterburt commented May 8, 2024

this PR adds changes for AreTomo2 compatibility and some useful debug output gated behind WARP_DEBUG=1

The AreTomo2 API is ~identical to AreTomo but when run on a stack called TS_11.st we end up with results called TS_11_st.xf in the TS_11_Imod folder

I also changed the way combinations of directories/filenames are generated so that you can easily specify a single tilt series directory in ts_import_alignments to only update a specific tilt series

closes #46

@alisterburt alisterburt marked this pull request as draft May 8, 2024 14:38
@alisterburt
Copy link
Contributor Author

alisterburt commented May 8, 2024

@jmdobbs @ThomasHoffmann77 this should be working but I've only been able to test alignment and import separately as I'm unable to get AreTomo2 built and running in the same environment as Warp right now - could you test and see if this solves your issues with alignment import at #41 ?

@jmdobbs
Copy link

jmdobbs commented May 8, 2024

can confirm it's working :)

there is an (extremely) slight formatting error in the output in the command line, 0/1 is in the same line as Importing 2D transforms ....

Running AreTomo with final average tilt axis angle:
0/1Importing 2D transforms from /struct/mahamid/jdobbs/warp2_testing/data_gseries/processing/tiltstack/gTS_003/gTS_003_Imod/gTS_003_st.xf
1/1, 00:00 remaining

@alisterburt
Copy link
Contributor Author

Awesome - thanks for running the test! I'll have to wait until we can run it in our infrastructure before merging 🙂

ThomasHoffmann77 added a commit to ThomasHoffmann77/easybuild-easyconfigs that referenced this pull request May 10, 2024
@alisterburt alisterburt marked this pull request as ready for review May 10, 2024 13:58
@alisterburt
Copy link
Contributor Author

confirmed working on our infra, thanks again @jmdobbs !

@alisterburt alisterburt merged commit cdaf0e2 into main May 10, 2024
@alisterburt
Copy link
Contributor Author

fyi @dtegunov compatible AreTomo2 is now available under the 'aretomo2' module in our module system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: update ts_aretomo WarpTool to AreTomo2
2 participants