Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add regex for alternate typo of onchanges #286

Merged
merged 1 commit into from Dec 16, 2022
Merged

[FEATURE] Add regex for alternate typo of onchanges #286

merged 1 commit into from Dec 16, 2022

Conversation

nicholasmhughes
Copy link
Contributor

Add to the existing rule to catch onchanges typos:

on_change:
on_change_any:
on_change_in:
on_changes:
on_changes_any:
on_changes_in:

@M3GH4NN
Copy link

M3GH4NN commented Dec 15, 2022

@jbouter @sblaisot @roaldnefs could one of you you take a look at this PR? or could you point me in the direction of someone who could help? Thanks in advance.

@roaldnefs roaldnefs self-requested a review December 16, 2022 19:29
roaldnefs
roaldnefs approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@roaldnefs roaldnefs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! This might indeed help to catch additional typos. My apologies for the late review.

@roaldnefs roaldnefs merged commit 71c6e78 into warpnet:main Dec 16, 2022
@nicholasmhughes nicholasmhughes deleted the add-requisite-typo-cases branch December 20, 2022 15:17
@roaldnefs roaldnefs added this to the Version 0.9.0 release milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaldnefs roaldnefs roaldnefs approved these changes

@M3GH4NN M3GH4NN M3GH4NN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.9.0 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicholasmhughes @M3GH4NN @roaldnefs