Fix encoding to use utf-8 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix encoding to use utf-8 by default in Python 2, the default encoding
in Python 3 is already utf-8. This fix will wrap `sys.stdout` in a
object that automatically encodes an unicode string into utf-8, in
Python 2 only.
An alternative to this would be to set the `PYTHONIOENCODING='utf-8'`
environment variable before running `salt-lint`, but this would require
an extra action on the user side.
The old solution using `str.encode('utf-8')` caused byte string (e.g.
`b''`) output in Python 3...
Fixes #74.
Signed-off-by: Roald Nefs <roald@warpnet.nl>
jbouter
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix encoding to use utf-8 by default in Python 2, the default encoding in Python 3 is already utf-8. This fix will wrap
sys.stdoutin a object that automatically encodes an unicode string into utf-8, in Python 2 only.An alternative to this would be to set the
PYTHONIOENCODING='utf-8'environment variable before runningsalt-lint, but this would require an extra action on the user side.The old solution using
str.encode('utf-8')caused byte string (e.g.b'') output in Python 3...Fixes #74.