Sketch of possible API for local workspace situation reporting. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is foremost an outline and proof-of-concept that we can split definitions of our schema into multiple files, and reuse the main warpforge API schema types in this second, superset schema. The actual message types declared in this diff are a sketch only, and not firmly committed to.
| // concat returns a new schemadmt that's got the types from both. | ||
| // | ||
| // This function could probably be hoisted upstream. | ||
| func concat(a, b *schemadmt.Schema) *schemadmt.Schema { |
There was a problem hiding this comment.
This function should return an error and have the anonymous init function above do the panics. An upstream version of it wouldn't panic.
TripleDogDare
approved these changes
Dec 22, 2022
|
This will be included in #58 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is foremost an outline and proof-of-concept that we can split definitions of our schema into multiple files, and reuse the main warpforge API schema types in this second, superset schema. And yep: that works. (I did something a tad hacky to achieve it. I'll try to push at least some of that towards upstream. It's mild, though.)
The actual message types declared in this diff are a sketch only, and not firmly committed to.