Implement view for an info.pedia page #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing an old PR #28 , now updated for the current code.
In addition to the features mentioned by that PR, here are the additional improvements.
You no longer need to be logged in to be able to view the page
The WikiLive hosts each section as its own live view. This makes it easier to be modified or appended. (I intend to add a short description of the major mechanics of the game)
The resource categories are now changed to suit a descriptive purpose more than their structure. Flavor texts are considered placeholder and may be changed.
The buildable tooltip is its own separate live view. This view is used in the wiki, but it can also be used in city_view to simply code.
The resource and buildable list are sectioned with the
<details>tag, and can be collapsed.I sourced an icon for education, from here: https://www.svgrepo.com/svg/89864/open-book You may use a different icon if you wish.
Supporting modules have been added to separate specific configurations from the view. This means wiki_live (and city_live) can fetch them and not need to maintain their own copies of their definitions.
city_stock_displayis not yet used, but is intended for use with the different forms of stock display on city_viewThis PR does not edit city_view nor any of the city calculations, and should not affect them.