Fix bug in keep-versions logic where dangling partials were removed.

If the most recent backups were partials (and not followed by a full backup), they should not be removed. A partial backup should only be removed if it is followed by a full backup. This concerns issue duplicati#3982.
warwickmm · Nov 29, 2019 · a47175a · a47175a
1 parent afecf89
commit a47175a
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/Duplicati/Library/Main/Operation/DeleteHandler.cs b/Duplicati/Library/Main/Operation/DeleteHandler.cs
@@ -239,16 +239,17 @@ private DateTime[] GetFilesetsToDelete(Database.LocalDeleteDatabase db, DateTime
                     bool isFullBackup = db.IsFilesetFullBackup(backup);
                     if (isFullBackup)
                     {
-                        if (haveFullBackup)
-                        {
-                            toDelete.AddRange(intermediatePartials);
-                            intermediatePartials.Clear();
-                        }
+                        toDelete.AddRange(intermediatePartials);
+                        intermediatePartials.Clear();
                         haveFullBackup = true;
                     }
                     else
                     {
-                        intermediatePartials.Add(backup);
+                        // Only consider a partial backup for deletion if we have already encountered a full backup.
+                        if (haveFullBackup)
+                        {
+                            intermediatePartials.Add(backup);
+                        }
                     }
 
                     if (fullVersionsKeptCount < fullVersionsToKeep)