when transfering units on the move

[Berg53]

When you transfere trucks or tanks to a ally if they moving to s pre selected spot they stop as soon as you transfere them

[Forgon2100]

The problem is caused by commit 9830d8d.
Instead of transferring a unit, it is destroyed and a new one is created in its place.

The problem can be fixed by simply copying all necessary droid data (actions,
orders, movement data etc.) from the old droid to the new one.
I have tested this so far by simulating a multiplayer game by connecting to
localhost. When handing over a circling VTOL, it no longer falls out of the sky.

I did also discover an old bug: All transferred units are fully loaded!
This means that you can for instance simply swap a large number of VTOLs with
your ally to rearm them instantly and attack the enemy again, without any pads.
Again, I have been able to test and fix this.

However, there remain a few edge cases in which my solution does not work,
for example when a unit is sent to attack an enemy target out of its reach.
In this case, the unit will stop when being transferred and refuse to move.

So there is some more work for me to be done...

[Cyp]

I think it should do the destroying/recreating (which both clears its orders and clears orders to kill it) if transferring to an enemy via the nexus link turret, but should just change owner if transferring to an ally voluntarily.

Maybe there could also be an option to give structures to allies, not sure.

[Forgon2100]

I think it should do the destroying/recreating (which both clears its orders and clears orders to kill it) if transferring to an enemy via the nexus link turret, but should just change owner if transferring to an ally voluntarily.

Good point.

Maybe there could also be an option to give structures to allies, not sure.

Nexus Link Turrets cannot capture structures in skirmish and multiplayer games.
Structure transfer to allies is supposed to be possible, but (in my opinion)
not worth implementing.

[KJeff01]

I did also discover an old bug: All transferred units are fully loaded!
This means that you can for instance simply swap a large number of VTOLs with
your ally to rearm them instantly and attack the enemy again, without any pads.
Again, I have been able to test and fix this.

That can go into a separate PR.

[maxsupermanhd]

Somebody will add this properties here(

warzone2100/src/droid.cpp

Line 3033 in bafc8a4

psNewDroid->experience = psD->experience;

)?

[KJeff01]

@Forgon2100 Are you working on this still? I could take on the rest of your work if you wish.

EDIT: I have a solution here.