Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slash breaks URL in RSS feed #61

Closed
nicosomb opened this issue Mar 3, 2023 · 2 comments
Closed

Trailing slash breaks URL in RSS feed #61

nicosomb opened this issue Mar 3, 2023 · 2 comments
Assignees
@boerniee
Labels
bug Something isn't working

Comments

@nicosomb
Copy link
Contributor

nicosomb commented Mar 3, 2023

Thank you for photo-stream!

In the .env file, I put https://mywebsite.com/ for the URL setting, but in the generated RSS feed, I have <media:thumbnail xmlns:media="http://search.yahoo.com/mrss/" url="https://mywebsite.com//photos/large/IMG_2809-686656.jpeg" /> with 2 slashes.

It should be removed but I don't see how I can fix it quickly.
@boerniee
Copy link
Collaborator

boerniee commented Mar 3, 2023

Hi,
thank you for your issue. I will have a look at this. We should handle the site url programmatically so we dont have to rely on the trailing slash in the configuration.

@waschinski waschinski added the bug Something isn't working label Mar 14, 2023
@waschinski
Copy link
Owner

This will be a breaking change in the next release.

@waschinski waschinski mentioned this issue Mar 16, 2023
Merged
pull bot pushed a commit to OrangeCatSleepless/photo-stream that referenced this issue Mar 18, 2023
@waschinski
Env URL no longer needs trailing slash, fixes waschinski#61
7525d92 
Former-commit-id: 991719a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boerniee boerniee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicosomb @waschinski @boerniee