-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lang it #122
Add lang it #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just wonder why you labeled the directory values-b+it
and not values-it
.
@waseefakhtar : Check it out here: https://stackoverflow.com/questions/44519520/android-localization-how-to-use-values-folder-b-qualifier At the moment I have no way to test it, see if you can the folder must be called |
Okay it makes sense. I tested it and it works great! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @Angelk90! :)
@waseefakhtar : I did a quick test of the app on the device, some translations are missing. |
Good catch! I assume those were some hardcoded values from the app? Feel free to extract those to String resources and translate them too. :) |
@waseefakhtar : Once you've got these strings sorted out, I'll try to translate them. |
Good catch! We should definitely fix those. |
#120