Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang it #122

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Add lang it #122

merged 2 commits into from
Dec 2, 2023

Conversation

Angelk90
Copy link
Contributor

@Angelk90 Angelk90 commented Nov 30, 2023

Copy link
Owner

@waseefakhtar waseefakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just wonder why you labeled the directory values-b+it and not values-it.

@Angelk90
Copy link
Contributor Author

Angelk90 commented Dec 2, 2023

@waseefakhtar : Check it out here: https://stackoverflow.com/questions/44519520/android-localization-how-to-use-values-folder-b-qualifier

At the moment I have no way to test it, see if you can the folder must be called values-b+it or values-it.

@waseefakhtar
Copy link
Owner

@waseefakhtar : Check it out here: https://stackoverflow.com/questions/44519520/android-localization-how-to-use-values-folder-b-qualifier

At the moment I have no way to test it, see if you can the folder must be called values-b+it or values-it.

Okay it makes sense. I tested it and it works great! :)

Copy link
Owner

@waseefakhtar waseefakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Angelk90! :)

@waseefakhtar waseefakhtar added this to In progress 🚧 in Dose App via automation Dec 2, 2023
@waseefakhtar waseefakhtar added this to the 1.3 milestone Dec 2, 2023
@waseefakhtar waseefakhtar merged commit 788cf54 into waseefakhtar:main Dec 2, 2023
1 check passed
Dose App automation moved this from In progress 🚧 to Ready 🚀 Dec 2, 2023
@Angelk90
Copy link
Contributor Author

Angelk90 commented Dec 2, 2023

@waseefakhtar : I did a quick test of the app on the device, some translations are missing.

@waseefakhtar
Copy link
Owner

@waseefakhtar : I did a quick test of the app on the device, some translations are missing.

Good catch! I assume those were some hardcoded values from the app? Feel free to extract those to String resources and translate them too. :)

@Angelk90
Copy link
Contributor Author

Angelk90 commented Dec 2, 2023

@waseefakhtar : Screenshot_20231202-124034~2.png

Screenshot_20231202-124141~2.png

@Angelk90
Copy link
Contributor Author

Angelk90 commented Dec 2, 2023

@waseefakhtar : Once you've got these strings sorted out, I'll try to translate them.

@waseefakhtar
Copy link
Owner

@waseefakhtar : Screenshot_20231202-124034~2.png

Screenshot_20231202-124141~2.png

Good catch! We should definitely fix those.

@Angelk90 Angelk90 deleted the patch-1 branch December 2, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dose App
Ready 🚀
Development

Successfully merging this pull request may close these issues.

None yet

2 participants