Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all Gradle files from Groovy to Kotlin #132

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

ankur141295
Copy link
Contributor

@ankur141295 ankur141295 commented Dec 16, 2023

This pull request contains the following changes:

  • Gradle files migrated from Groovy to Kotlin.
  • BuildScript has been removed in favor of Plugins from the Top-Level Gradle File. See this
  • The app-level Gradle file's plugins block now gets plugin information from a .toml file. Additionally, the compile-sdk, target-sdk, min-sdk, version-code, and version-name data also come from the .toml file.

This change closes #121

@waseefakhtar Please review the changes and let me know if you have any questions.

Copy link
Owner

@waseefakhtar waseefakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👏

Just one question: Are you sure compile-sdk, target-sdk, min-sdk, version-code, and version-name is retrieved from the .toml file? .toml mentions they're not used anywhere and cmd-clicking on libs.versions.min.sdk.version.get().toInt() shows another declaration.

@waseefakhtar waseefakhtar added the refactor Restructuring or optimizing code without changing its external behavior label Dec 22, 2023
@waseefakhtar waseefakhtar added this to In progress 🚧 in Dose App via automation Dec 22, 2023
@waseefakhtar waseefakhtar added this to the 1.3 milestone Dec 22, 2023
@ankur141295
Copy link
Contributor Author

This looks great! 👏

Just one question: Are you sure compile-sdk, target-sdk, min-sdk, version-code, and version-name is retrieved from the .toml file? .toml mentions they're not used anywhere and cmd-clicking on libs.versions.min.sdk.version.get().toInt() shows another declaration.

I'm not sure why the usage of some properties isn't displayed in the .toml file. However, if you command-click to open the generated file, you can still see that the declared property is being referenced. For example
Screenshot 2023-12-24 at 1 07 38 PM

Additionally, the Kotlin Compiler Version is also sourced from the .toml file, but it's marked as unused there. However, this code is preexisting and functioning properly.

@waseefakhtar
Copy link
Owner

This looks great! 👏
Just one question: Are you sure compile-sdk, target-sdk, min-sdk, version-code, and version-name is retrieved from the .toml file? .toml mentions they're not used anywhere and cmd-clicking on libs.versions.min.sdk.version.get().toInt() shows another declaration.

I'm not sure why the usage of some properties isn't displayed in the .toml file. However, if you command-click to open the generated file, you can still see that the declared property is being referenced. For example Screenshot 2023-12-24 at 1 07 38 PM

Additionally, the Kotlin Compiler Version is also sourced from the .toml file, but it's marked as unused there. However, this code is preexisting and functioning properly.

Okay that makes sense! 👌

Copy link
Owner

@waseefakhtar waseefakhtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @ankur141295! ✨

@waseefakhtar waseefakhtar merged commit 703513c into waseefakhtar:main Dec 25, 2023
1 check passed
Dose App automation moved this from In progress 🚧 to Ready 🚀 Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Restructuring or optimizing code without changing its external behavior
Projects
Dose App
Ready 🚀
Development

Successfully merging this pull request may close these issues.

Migrate all Gradle files from Groovy to Kotlin and enhance the existing ones.
2 participants