-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate all Gradle files from Groovy to Kotlin #132
Migrate all Gradle files from Groovy to Kotlin #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! 👏
Just one question: Are you sure compile-sdk, target-sdk, min-sdk, version-code, and version-name is retrieved from the .toml file? .toml mentions they're not used anywhere and cmd-clicking on libs.versions.min.sdk.version.get().toInt()
shows another declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @ankur141295! ✨
This pull request contains the following changes:
This change closes #121
@waseefakhtar Please review the changes and let me know if you have any questions.