Fix issue #116 and enable predictive back gesture #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waseefakhtar
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Looks brilliant @GitGitro! 🚀
Love to see the same convention and style of phrases followed and love the new tracking events added! 👏 Smart regarding enabling predictive back gesture as well. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
i gave a try to fix the issue with alarms and reminders on A14, whta it does is it will asks for another permission on A14 and up following the style for the notification permission.
i also enabled enableOnBackInvokedCallback so now it comes with a pretty back animation
Hope this is okay! it's the first time with jetpack compose so any input is appreciated :D
Resolves #116