Snack Bar implemented throughout the app #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waseefakhtar
reviewed
Nov 6, 2023
app/src/main/java/com/waseefakhtar/doseapp/util/SnackBarUtil.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Waseef Akhtar <waseefakhtar@gmail.com>
Co-authored-by: Waseef Akhtar <waseefakhtar@gmail.com>
Co-authored-by: Waseef Akhtar <waseefakhtar@gmail.com>
|
Let me change them overall the app as I've seen there are others as well need to update |
|
Hello @waseefakhtar, I've improved the implementation of the Snackbar feature. Now, you can simply call the function (showSnackbar()) without the need to create parameters within it. This eliminates any unnecessary boilerplate code, making it a more efficient and user-friendly experience for future developers. I'm eager to hear your thoughts and hope we can proceed with merging this improvement. 😊 |
waseefakhtar
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Looks pretty good and nice improvement with eliminating unnecessary boilerplate code! I just made some minor changes renaming variables and functions and fixing ktlint. Thank you for your contribution, @Ammar-Ishfaq! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #71