Add support for version 8.4 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Thank you. Can you run the |
|
Good catch! Should be updated now. |
freedmand
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings the
mappings.jsonfile up to date with the current version in the fecfile python library. The most noteworthy change is supporting version 8.4 of the .fec file format. Here is the corresponding commit to the fech-source library. It appears as though the only differences between versions 8.3 and 8.4 are the addition of thelobbyist_registrant_pac_3andlobbyist_registrant_pac_4fields to the F1, coming right afterleadership_pac.This PR also also includes a fix to version 2 of the schedule A, added by this commit.
Link to Jira Ticket
Test Steps
After Screenshot(s)
Before Screenshot(s)