feat: remove non-wheel artifacts for PyPI publish #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make any sense to upload the wheel artifact with a specific name, so you can download just that named artifact from with the download-artifact action instead of downloading all and then deleting some? |
|
It’s 6 different files. They have specific names tuned to the
OS/architecture combo. The commonality is the .whl. There are 13 other
files that get deleted and they’re approx 200-300kb each
…On Wed, Aug 3, 2022 at 3:15 AM Chris Zubak-Skees ***@***.***> wrote:
Would it make any sense to upload the wheel artifact with a specific name,
so you can download just that named artifact from with the
download-artifact action instead of downloading all and then deleting some?
—
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKXL6G7GH54MPKOEIBVJLVXIL77ANCNFSM55ND3PPQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@freedmand I'm going by the docs, which seem to indicate you can name supply a name when you upload the artifacts and then use that name to download just that named artifact. I could be misinterpreting it, though. |
|
The artifact named "artifact," which is what you're downloading, is just the default name if no name is supplied at upload. |
|
Thanks, @chriszs, that makes sense. Let me know if this refactor looks good |
chriszs
approved these changes
Aug 3, 2022
|
Yes! Approved. |
freedmand
added a commit
that referenced
this pull request
Aug 4, 2022
* Sync main->dev (#39) * v0.1.0 (#37) * Remove external deps (Curl) and refactor release process (#35) * fix: remove curl and get pcre to work as natural dependency * feat: readme updates, mappings test script * feat: reusable github workflow revision * fix: license includes BSD/PCRE, fix tests * fix: don't rely on windows compress-archive * fix: refactor release workflow, bump timeout to 10 mins * fix: add input for pr-release workflow * fix: refactor workflows to use nested with format * feat: CLI tests * chore: remove unneeded cli test comments * docs: update docquery->filing urls, and secondary -> converted paper * fix: trailing cli filing id bug * fix a few oversights with v8.4 mappings (#31) Co-authored-by: Dylan Freedman <freedmand@gmail.com> * Fix custom write function segfault (#32) * DENG-116 Change buffer size * Revert "DENG-116 Change buffer size" This reverts commit 0ae41c3. * Use a POINTER(c_char) instead of a c_char_p for CUSTOM_WRITE contents * Add a smoke test for filing 1606847 Co-authored-by: crystaljg <70042918+crystaljg@users.noreply.github.com> Co-authored-by: Crystal Gong <cgong@actbluetech.com> * fix: release to latest tag, bump to 0.1.0 (#36) Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com> Co-authored-by: Evan Sonderegger <evan@rpy.xyz> Co-authored-by: james-clemer-actblue <69259105+james-clemer-actblue@users.noreply.github.com> Co-authored-by: crystaljg <70042918+crystaljg@users.noreply.github.com> Co-authored-by: Crystal Gong <cgong@actbluetech.com> * fix: main release workflow bug * feat: 0.1.1 * feat: use ref name to get current tag * feat: version 0.1.3 Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com> Co-authored-by: Evan Sonderegger <evan@rpy.xyz> Co-authored-by: james-clemer-actblue <69259105+james-clemer-actblue@users.noreply.github.com> Co-authored-by: crystaljg <70042918+crystaljg@users.noreply.github.com> Co-authored-by: Crystal Gong <cgong@actbluetech.com> * fix: upload artifacts in release process (#40) * fix: upload artifacts in release process * fix: erroneous steps * fix: run wheels on all platforms * fix: add inputs prefix to if conditionals in actions * feat: bump version to 0.1.4 * feat: GH actions matrix * fix: add exe ext to actions map * feat: remove apt-get update * fix: give windows the .exe extension, not linux * feat: matrix for wheels as well * test: speed up test workflow * feat: split test workflow into two parallel tracks test c and test python * fix: missing actions checkout step added * feat: remove non-wheel artifacts for PyPI publish (#41) * test: use uppercase secrets * feat: refactor pypiToken as reusable workflow input * fix: pass secrets properly * fix: pass secrets properly * test: pass secrets appropriately * test: inherit secrets * test: remove type from secrets * test: remove secrets section Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com> Co-authored-by: Evan Sonderegger <evan@rpy.xyz> Co-authored-by: james-clemer-actblue <69259105+james-clemer-actblue@users.noreply.github.com> Co-authored-by: crystaljg <70042918+crystaljg@users.noreply.github.com> Co-authored-by: Crystal Gong <cgong@actbluetech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The beta release failed because the GitHub actions step that downloads artifacts and then uploads them to PyPI will upload ALL artifacts, even those from other jobs. We only want Wheel files to trickle through. We won't know if this works until we merge to dev