This repository has been archived by the owner on May 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
feat: add initial wasmcloud wasi kv implementation #198
Closed
vados-cosmonic
wants to merge
1
commit into
wasmCloud:componentize
from
vados-cosmonic:feat/add-wasmcloud-wasi-kv
Closed
feat: add initial wasmcloud wasi kv implementation #198
vados-cosmonic
wants to merge
1
commit into
wasmCloud:componentize
from
vados-cosmonic:feat/add-wasmcloud-wasi-kv
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
requested review from
autodidaddict,
brooksmtownsend and
stevelr
as code owners
March 10, 2023 19:18
brooksmtownsend
previously requested changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two non-code requests, but I mostly requested changes for cleanliness and language
- Should the Wasm binary files be committed here? Normally we've ignored them but wasn't sure if they were included on purpose
- Can we put this under a top-level folder like
wasi-components
or something more general, rather than this specific folder? Eventually, I'd hope all our examples can be like this
vados-cosmonic
force-pushed
the
feat/add-wasmcloud-wasi-kv
branch
3 times, most recently
from
March 14, 2023 14:48
9668930
to
cd09483
Compare
rvolosatovs
reviewed
Mar 14, 2023
rvolosatovs
reviewed
Mar 14, 2023
rvolosatovs
reviewed
Mar 14, 2023
rvolosatovs
reviewed
Mar 14, 2023
rvolosatovs
reviewed
Mar 14, 2023
rvolosatovs
reviewed
Mar 14, 2023
rvolosatovs
reviewed
Mar 14, 2023
rvolosatovs
reviewed
Mar 14, 2023
rvolosatovs
reviewed
Mar 14, 2023
vados-cosmonic
force-pushed
the
feat/add-wasmcloud-wasi-kv
branch
from
March 14, 2023 17:04
1042fcd
to
c8ae761
Compare
ricochet
reviewed
Mar 14, 2023
brooksmtownsend
dismissed
their stale review
March 20, 2023 14:32
dismissing requests as they are resolved, but haven't reviewed again to give full approval
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat/add-wasmcloud-wasi-kv
branch
from
March 20, 2023 19:38
1191191
to
a15e88f
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Add an implementation wasi keyvalue contract that allows building fused components.
See the rendered Markdown README for a more thorough explanation.
While the code in there right now errors for all keyvalue interface bits, I will be changing that to
wasmbus
Related Issues
N/A
Release Information
componentize
v1.0.0Consumer Impact
Consumers can try out the component model with wasmCloud
Testing
N/A
Built on platform(s)
Tested on platform(s)
Unit Test(s)
N/A
Acceptance or Integration
N/A
Manual Verification
N/A