Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

feat: add initial wasmcloud wasi kv implementation #198

Conversation

vados-cosmonic
Copy link
Contributor

@vados-cosmonic vados-cosmonic commented Mar 10, 2023

Feature or Problem

Add an implementation wasi keyvalue contract that allows building fused components.

See the rendered Markdown README for a more thorough explanation.

While the code in there right now errors for all keyvalue interface bits, I will be changing that to wasmbus

Related Issues

N/A

Release Information

componentize v1.0.0

Consumer Impact

Consumers can try out the component model with wasmCloud

Testing

N/A

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

N/A

Acceptance or Integration

N/A

Manual Verification

N/A

@vados-cosmonic vados-cosmonic changed the base branch from main to componentize March 10, 2023 19:19
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two non-code requests, but I mostly requested changes for cleanliness and language

  • Should the Wasm binary files be committed here? Normally we've ignored them but wasn't sure if they were included on purpose
  • Can we put this under a top-level folder like wasi-components or something more general, rather than this specific folder? Eventually, I'd hope all our examples can be like this

wasmcloud-wasi-kv/README.md Outdated Show resolved Hide resolved
wasmcloud-wasi-kv/kv-demo/Cargo.toml Outdated Show resolved Hide resolved
wasmcloud-wasi-kv/kv-demo/src/lib.rs Outdated Show resolved Hide resolved
wasmcloud-wasi-kv/wasmcloud-wasi-kv-cc/Cargo.toml Outdated Show resolved Hide resolved
wasmcloud-wasi-kv/wasmcloud-wasi-kv-wit/Cargo.toml Outdated Show resolved Hide resolved
wasmcloud-wasi-kv/wasmcloud-wasi-kv-wit/src/lib.rs Outdated Show resolved Hide resolved
wasmcloud-wasi-kv/README.md Outdated Show resolved Hide resolved
wasmcloud-wasi-kv/README.md Outdated Show resolved Hide resolved
@vados-cosmonic vados-cosmonic force-pushed the feat/add-wasmcloud-wasi-kv branch 3 times, most recently from 9668930 to cd09483 Compare March 14, 2023 14:48
@brooksmtownsend brooksmtownsend dismissed their stale review March 20, 2023 14:32

dismissing requests as they are resolved, but haven't reviewed again to give full approval

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@stale
Copy link

stale bot commented May 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label May 19, 2023
@stale stale bot closed this May 26, 2023
@vados-cosmonic vados-cosmonic deleted the feat/add-wasmcloud-wasi-kv branch August 31, 2023 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants