Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*)!: 1.0 compatible #9

Merged
merged 8 commits into from
May 30, 2024
Merged

feat(*)!: 1.0 compatible #9

merged 8 commits into from
May 30, 2024

Conversation

brooksmtownsend
Copy link
Member

@brooksmtownsend brooksmtownsend commented May 6, 2024

Feature or Problem

This PR is updating the provider SDK to match 1.0-compatible topics, structures, etc.

Notably this does not yet include the wRPC implementation which is separately implemented and will be imported here as a module.

Related Issues

Follow up #11

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

The health and shutdown topics were manually verified

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend changed the title feat/1.0 compatible feat(*)!: 1.0 compatible May 6, 2024
Copy link

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking pretty good

host.go Show resolved Hide resolved
link.go Show resolved Hide resolved
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend marked this pull request as ready for review May 10, 2024 15:11
@brooksmtownsend brooksmtownsend requested a review from a team as a code owner May 10, 2024 15:11
@brooksmtownsend
Copy link
Member Author

This is good enough for now with an example, there's more documentation to follow

examples/keyvalue-inmemory/main.go Outdated Show resolved Hide resolved
examples/keyvalue-inmemory/main.go Outdated Show resolved Hide resolved
examples/keyvalue-inmemory/main.go Show resolved Hide resolved
examples/keyvalue-inmemory/build.sh Outdated Show resolved Hide resolved
@brooksmtownsend brooksmtownsend force-pushed the feat/1.0-compatible branch 2 times, most recently from 6082268 to ab66063 Compare May 22, 2024 14:36
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>

real example

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Copy link

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to go except for parsing the proper type out of incoming host data

host.go Outdated Show resolved Hide resolved
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend merged commit f67e907 into main May 30, 2024
1 check passed
@brooksmtownsend brooksmtownsend deleted the feat/1.0-compatible branch May 30, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants