feat(*): Handle deploy operations #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please note that this doesn't try to do any sort of notification event when something is deployed. That will have to be handled later Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
brooksmtownsend
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Just like the breaking change to destructive undeploy, I like the idea of making put an operation that deploys by default, unless run with a --put-only or whatever command. Just feels nice to be able to do an essential kubectl apply with a manifest
edit: this was just a thought and doesn't need to happen in this PR
| if manifest.version() == LATEST_VERSION { | ||
| self.send_error( | ||
| msg.reply, | ||
| format!("A manifest with a version {LATEST_VERSION} is not allowed in wadm"), |
There was a problem hiding this comment.
Make sure to document this bad boy 😉
There was a problem hiding this comment.
No changes needed here. Just something we'll want to note when mentioning OAM versions
|
@brooksmtownsend I actually thought about adding something about "put only" but then we have a separate request envelope we have to add. I'll add an issue as a follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this doesn't try to do any sort of notification event when something is deployed. That will have to be handled later