(feat) Implement the ActorSpreadScaler #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
feat/spreadscaler-impl
branch
from
70e8ee4
to
4dbfbe0
Compare
brooksmtownsend
commented
Apr 10, 2023
brooksmtownsend
changed the title
brooksmtownsend
commented
Apr 10, 2023
brooksmtownsend
force-pushed
the
feat/spreadscaler-impl
branch
from
01a6194
to
19c2140
Compare
thomastaylor312
requested changes
Apr 12, 2023
Signed-off-by: Brooks Townsend <brooks@cosmonic.com> spreadscaler can compute commands Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com> updated update_config to trigger reconcile Signed-off-by: Brooks Townsend <brooks@cosmonic.com> added event handling and tests Signed-off-by: Brooks Townsend <brooks@cosmonic.com> cleaned up spreadscaler for review Signed-off-by: Brooks Townsend <brooks@cosmonic.com> added note about conflicting spreads Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
Signed-off-by: Brooks Townsend <brooks@cosmonic.com> satisfied clippy Signed-off-by: Brooks Townsend <brooks@cosmonic.com> mostly finished with state refactor, Scaler vec Signed-off-by: Brooks Townsend <brooks@cosmonic.com> Corrected simplescaler to match new state Signed-off-by: Brooks Townsend <brooks@cosmonic.com> modified tests in workers to use inventory Signed-off-by: Brooks Townsend <brooks@cosmonic.com> mostly updated spreadscaler tests Signed-off-by: Brooks Townsend <brooks@cosmonic.com> updated existing tests to work with annotations Signed-off-by: Brooks Townsend <brooks@cosmonic.com> reworked spreadscaler to use annotations Signed-off-by: Brooks Townsend <brooks@cosmonic.com> ensure spreadscaler annotations include wadm Signed-off-by: Brooks Townsend <brooks@cosmonic.com> pr cleanup, satisfy clippy overlord Signed-off-by: Brooks Townsend <brooks@cosmonic.com> updated state for event test Signed-off-by: Brooks Townsend <brooks@cosmonic.com> resolved nits in PR comments Signed-off-by: Brooks Townsend <brooks@cosmonic.com> compute spread requirements and store, once Signed-off-by: Brooks Townsend <brooks@cosmonic.com> removed Hash impl's and derives from command Signed-off-by: Brooks Townsend <brooks@cosmonic.com> efficiently initialize actor ID, remove extra annotation Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
brooksmtownsend
force-pushed
the
feat/spreadscaler-impl
branch
from
7c980c3
to
5674ec5
Compare
thomastaylor312
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
This PR adds the
ActorSpreadScaler, an implementation of theScalertrait which spreads replicas of actors across a list of spread requirements. It does not attempt to evenly spread on hosts that match requirements, as that's more complicated and better suited for another Scaler implementation.Currently marking as ready for review, but two (or three?) outstanding things I need to address
ScalerimplementationsFeature or Problem
Related Issues
Release Information
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Added multiple unit tests to ensure proper functionality of the spreadscaler
Manual Verification
I ran the tests but did not run for reals since the mechanism for publishing commands isn't hooked up quite yet