Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

feat: add wash dev command #610

Merged
merged 1 commit into from Jun 14, 2023
Merged

feat: add wash dev command #610

merged 1 commit into from Jun 14, 2023

Conversation

vados-cosmonic
Copy link
Contributor

Feature or Problem

Add wash dev command for local dev loops

Related Issues

Release Information

next

Consumer Impact

Users developing will be able to start one command to automatically work on actors

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

Verified manually

@vados-cosmonic
Copy link
Contributor Author

This still needs at least one E2E test, but it'll be a bit complicated to test, so putting this up while I work on that.

crates/wash-lib/src/config.rs Outdated Show resolved Hide resolved
src/dev.rs Outdated Show resolved Hide resolved
src/dev.rs Outdated Show resolved Hide resolved
src/dev.rs Outdated Show resolved Hide resolved
src/dev.rs Show resolved Hide resolved
let project_path = cmd.code_dir.unwrap_or(current_dir);
let project_cfg = get_config(Some(project_path.clone()), Some(true))?;

// Build the project (equivalent to `wash build`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you alluded to this as a refactor opportunity when we talked. Wanna file an issue so we could do something like handle_build in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh so I actually ended up doing it here... But I am open to making a polish ticket!

src/dev.rs Outdated Show resolved Hide resolved
src/dev.rs Outdated Show resolved Hide resolved
src/dev.rs Show resolved Hide resolved
@vados-cosmonic vados-cosmonic marked this pull request as ready for review June 13, 2023 15:38
@vados-cosmonic vados-cosmonic changed the title feat: add wash dev command feat(*): add wash dev command Jun 13, 2023
@vados-cosmonic vados-cosmonic changed the title feat(*): add wash dev command feat: add wash dev command Jun 13, 2023
@vados-cosmonic
Copy link
Contributor Author

Hey @connorsmith256 one more thing -- I forgot to put wash dev behind the WASH_EXPERIMENTAL flag, so I've added that

@vados-cosmonic
Copy link
Contributor Author

vados-cosmonic commented Jun 13, 2023

Looks like it takes a really long time for wash to set itself up to run in CI...

wash is getting downloaded and the host starts running but the test quits before it has time to finish. Going to give it a bunch of time since the tests pass locally (and the check for finished happens every 5 seconds, not waiting the whole time, so it could theoretically finish early)

[EDIT] - Hmnn, something must be wrong in CI at this point -- Will need to turn on some visibility (and probably make that an option like --show-logs) to figure out what wash up is up to.

connorsmith256
connorsmith256 previously approved these changes Jun 14, 2023
Copy link
Contributor

@connorsmith256 connorsmith256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge once tests pass 🤞

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@connorsmith256 connorsmith256 merged commit 00e0aea into wasmCloud:main Jun 14, 2023
18 of 20 checks passed
@vados-cosmonic vados-cosmonic deleted the feat/add-wash-dev branch June 15, 2023 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants