Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Lame Duck Mode #693

Closed
jordan-rash opened this issue Sep 26, 2023 · 6 comments
Closed

[REQUEST] Lame Duck Mode #693

jordan-rash opened this issue Sep 26, 2023 · 6 comments
Labels
host Issues pertaining to the host runtime wasmcloud-control-interface Issues pertaining to the control interface

Comments

@jordan-rash
Copy link
Member

As an extension to #692, I would like to see the "lame duck" tag implemented.

Similar to NATs lame duck mode, it would cause the host to drain itself and block further deployments (from wash and wadm) to the host. This would allow for easier updates of the host in place.

Ref: https://wasmcloud.slack.com/archives/C04RVMJJH17/p1695735058510099

@connorsmith256
Copy link
Contributor

Some questions on this one:

  • once in lame duck mode, should the host refuse to process any new control interface commands, or is this mode "just' part of what's returned by host pings/inventory requests?
  • once the host has drained its contents, will it shut down, or does it remain in lame duck mode?
    • if the host stays running, should there be a way to switch out of lame duck mode, or is this a terminal state?

@jordan-rash
Copy link
Member Author

IMO:

  • once lame duck mode is enabled, no "new" commands should be processed. All existing workloads should be shutdown nicely (up to some TTL and then killed)
  • I think once it is shutdown, it would remain on and continue to not respond to request. Reason for this is,
    1. maybe I was just troubleshooting something and will take it out of lame duck mode once I am done or
    2. Doing some sort of load testing
  • I def believe lame duck mode should be toggleable

@protochron
Copy link
Contributor

We've chatted about this before, and I'd also like to see this as a feature. Conceptually I think it as being closer to Kubernetes' drain/cordon behavior or Nomad's node draining/eligibility feature.

@jordan-rash
Copy link
Member Author

jordan-rash commented Oct 2, 2023

We've chatted about this before, and I'd also like to see this as a feature. Conceptually I think it as being closer to Kubernetes' drain/cordon behavior or Nomad's node draining/eligibility feature.

But Dan def thinks that the feature should have duck in the name...right, RIGHT?!?!?

@connorsmith256 connorsmith256 added wasmcloud-control-interface Issues pertaining to the control interface host Issues pertaining to the host runtime labels Nov 28, 2023
Copy link

stale bot commented Jan 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@thomastaylor312
Copy link
Contributor

@jordan-rash did you mean to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host Issues pertaining to the host runtime wasmcloud-control-interface Issues pertaining to the control interface
Projects
None yet
Development

No branches or pull requests

4 participants