Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Runtime Host Tags #692

Closed
jordan-rash opened this issue Sep 26, 2023 · 5 comments · Fixed by #1276
Closed

[REQUEST] Runtime Host Tags #692

jordan-rash opened this issue Sep 26, 2023 · 5 comments · Fixed by #1276
Labels
host Issues pertaining to the host runtime wash-cli Issues pertaining to the wash CLI wasmcloud-control-interface Issues pertaining to the control interface

Comments

@jordan-rash
Copy link
Member

I would like to be able to create tags on the host at runtime.

Something along the lines of
wash host <host-id> my:tag

This would be a powerful way to start tuning the host without restart. Currently, a problem I have is that if I forget to add a tag/label to the host, it requires a restart of the host.

Ref: https://wasmcloud.slack.com/archives/C04RVMJJH17/p1695735058510099

@connorsmith256
Copy link
Contributor

I love this idea 🙌

I think we'll want some more technical details ironed out:

  • when you say "tags", do you mean the existing host labels, or a new, separate set of metadata?
  • how will the host receive updates?
    • presumably a new topic on the control interface?
    • will the payload be treated as a full replacement, or an "upsert"?

@jordan-rash
Copy link
Member Author

By tags, I mean host labels (my mistake)

I don't know how the host should best receive them, but I do think they should be an insert and not a replace.

wash host add-label <host-id> my:tag
wash host del-label <host-id> my

@connorsmith256
Copy link
Contributor

@jordan-rash check out #780 and let me know if you have any feedback! Once the host/control interface supports this API, we can add it to wash pretty easily

@connorsmith256
Copy link
Contributor

@jordan-rash bump?

@jordan-rash
Copy link
Member Author

#780 looks great to me

@connorsmith256 connorsmith256 added wasmcloud-control-interface Issues pertaining to the control interface host Issues pertaining to the host runtime wash-cli Issues pertaining to the wash CLI labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host Issues pertaining to the host runtime wash-cli Issues pertaining to the wash CLI wasmcloud-control-interface Issues pertaining to the control interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants