refactor(wash-cli): move more wash invocations into TestWashInstance #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorsmith256
approved these changes
Nov 20, 2023
thomastaylor312
approved these changes
Nov 20, 2023
vados-cosmonic
force-pushed
the
feat/test/add-stop-methods-to-test-wash-instance
branch
from
7a83959
to
29b85f0
Compare
vados-cosmonic
deleted the
feat/test/add-stop-methods-to-test-wash-instance
branch
vados-cosmonic
restored the
feat/test/add-stop-methods-to-test-wash-instance
branch
`TestWashInstance` is a test utility struct that encapsulates (and tracks) child processes spawned by `wash` so that they can be cleaned up upon `drop()`, and information about spawned hosts can be retrieved. Some invocations of `wash` itself (normally from tests that ensure functionality works have been moved into `TestWashInstance` to make them easier to call -- with the *current* built version of `wash` (i.e. the cargo-provided ENV variable `CARGO_BIN_EXE_wash`). This commit adds more invocations (`wash start provider`, `wash stop actor`, `wash stop host`) into the `TestWashInstance` struct used from tests, shortening the code required for individual tests. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat/test/add-stop-methods-to-test-wash-instance
branch
from
8244da0
to
b0d8277
Compare
vados-cosmonic
deleted the
feat/test/add-stop-methods-to-test-wash-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
TestWashInstanceis a test utility struct that encapsulates (and tracks) child processes spawned bywashso that they can be cleaned up upondrop(), and information about spawned hosts can be retrieved.Some invocations of
washitself (normally from tests that ensure functionality works have been moved intoTestWashInstanceto make them easier to call -- with the current built version ofwash(i.e. the cargo-provided ENV variableCARGO_BIN_EXE_wash).This commit adds more invocations (
wash start provider,wash stop actor,wash stop host) into theTestWashInstancestruct used from tests, shortening the code required for individual tests.Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
All integration tests should be using the new code (and still passing)
Manual Verification
Verified manually