refactor: remove deprecated code related to start actor cmd #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed <ahmedtadde@gmail.com>
thomastaylor312
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Thanks again @ahmedtadde this is looking good! I think everything is good to go, but because this is a breaking removal, I'd also like at least @brooksmtownsend or @connorsmith256 to take a look and approve as well!
Whichever of you get to it first can go ahead and merge if you also approve
connorsmith256
previously requested changes
Dec 7, 2023
Signed-off-by: Ahmed <ahmedtadde@gmail.com>
brooksmtownsend
approved these changes
Dec 11, 2023
|
@ahmedtadde looks like the only CI failure is from |
Signed-off-by: Ahmed <ahmedtadde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
In #710 we introduced a few clippy warnings about deprecated control interface functionality in order to support the start actor command in a backwards compatible way. As of the control interface 0.29.0 and applicable wadm/wash versions (TBD), this command isn't used anywhere and can be fully removed instead of just deprecated.
Related Issues
#740
Release Information
wasmCloud v0.80&wash-cli v0.24.1Consumer Impact
there should be none
Testing
all unit tests and integration tests pass