refactor(providers): convert blobstore-s3 to provider bindgen #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
requested changes
Dec 11, 2023
vados-cosmonic
force-pushed
the
refactor/convert-blobstore-s3-to-bindgen
branch
from
6f779ad
to
ba0448f
Compare
connorsmith256
approved these changes
Dec 11, 2023
vados-cosmonic
force-pushed
the
refactor/convert-blobstore-s3-to-bindgen
branch
from
795f3e4
to
25f9e24
Compare
vados-cosmonic
force-pushed
the
refactor/convert-blobstore-s3-to-bindgen
branch
from
25f9e24
to
15389f0
Compare
brooksmtownsend
approved these changes
Dec 12, 2023
vados-cosmonic
force-pushed
the
refactor/convert-blobstore-s3-to-bindgen
branch
2 times, most recently
from
e544d92
to
18bc568
Compare
The blobstore-s3 provider provides access to S3-compatible object storage from a given wasmcloud lattice. While in the past the provider was based on Smithy contracts and the somewhat older wasmcloud provider toolchain, WIT support has matured such that it can be supported as a new WIT world. This commit converts the previously vendored blobstore-s3 provider into one that operates via provider-wit-bindgen. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
refactor/convert-blobstore-s3-to-bindgen
branch
from
dcc667a
to
3d024ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
The blobstore-s3 provider provides access to S3-compatible object storage from a given wasmcloud lattice. While in the past the provider was based on Smithy contracts and the somewhat older wasmcloud provider toolchain, WIT support has matured such that it can be supported as a new WIT world.
This commit converts the previously vendored blobstore-s3 provider into one that operates via provider-wit-bindgen.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification