Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update golang example to wasmtime 16 #1185

Conversation

vados-cosmonic
Copy link
Contributor

Feature or Problem

With the fast-moving development of WebAssembly ecosystem, WASI, the Component Model, and WIT have seen many changes in the last couple months.

For example, The existing golang echo example in the repo was originally built when wit-bindgen version 0.13.1 was the most important version, and upstream wit-bindgen is now at 0.16.0. As wit-bindgen reflects releases of wasmtime and the ecosystem as a whole, there's been a lot of sales.

This commit updates the golang example echo actor to use the WIT and related generated bindings for newer versions of wasmtime 16 and related WIT definitions, including resources.

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

With the fast-moving development of WebAssembly ecosystem, WASI, the
Component Model, and WIT have seen many changes in the last couple months.

For example, The existing golang echo example in the repo was
originally built when wit-bindgen version 0.13.1 was the most
important version, and upstream wit-bindgen is now at 0.16.0. As
wit-bindgen reflects releases of wasmtime and the ecosystem as a
whole, there's been a lot of sales.

This commit updates the golang example echo actor to use the
WIT and related generated bindings for newer versions of wasmtime 16
and related WIT definitions, including resources.

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@vados-cosmonic vados-cosmonic requested review from a team as code owners December 15, 2023 17:59
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing that I think can be removed, LGTM

@brooksmtownsend brooksmtownsend merged commit c5644a8 into wasmCloud:main Dec 15, 2023
47 checks passed
@vados-cosmonic vados-cosmonic deleted the refactor/update-tinygo-example-for-wasmtime-16 branch December 18, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants