feat: consistently prefix wash-cli arguments #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailelagi
force-pushed
the
feat/consistently-namespace-cli-env-variables-wasmcloud_
branch
from
5819258
to
8491ef2
Compare
hailelagi
changed the title
vados-cosmonic
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
LGTM 🚀
Thanks for the contribution @hailelagi, let's run the CI and we should be good to merge.
Signed-off-by: Haile Lagi <52631736+hailelagi@users.noreply.github.com>
hailelagi
force-pushed
the
feat/consistently-namespace-cli-env-variables-wasmcloud_
branch
from
6b119e1
to
41a4206
Compare
brooksmtownsend
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Awesome! One more task checked off the 1.0 list, thank you @hailelagi
vados-cosmonic
added a commit
to vados-cosmonic/wasmCloud
that referenced
this pull request
Jan 30, 2024
This commit removes what were supposed to be ENV aliases that don't work, which were introduced by wasmCloud#1243 Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
added a commit
to vados-cosmonic/wasmCloud
that referenced
this pull request
Jan 30, 2024
This commit removes what were supposed to be ENV aliases that don't work, which were introduced by wasmCloud#1243 Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
added a commit
that referenced
this pull request
Jan 30, 2024
This commit removes what were supposed to be ENV aliases that don't work, which were introduced by #1243 Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
consistent namespace prefixes for cli flags
Related Issues
#1102
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification