Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): add logging and keyvalue for tutorial use #1266

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

brooksmtownsend
Copy link
Member

@brooksmtownsend brooksmtownsend commented Jan 2, 2024

Feature or Problem

This PR adds wasi:keyvalue and wasi:logging to the wit dependencies for both of our hello world examples for use in the quickstart tutorials. Without this, developers would need to manually modify the deps.toml file and run wit-deps update, so now during the quickstart documentation they can simply add these imports to their wit/hello.wit file and then use the capabilities.

This is only a temporary fix. Ideally these examples don't come with a wit deps directory at all and the only wit modification needed will be to specify custom import/exports, and a crate like wasmcloud-actor would be used to wrap wit definitions. I think that it's important to start here as a baseline and then remove some of the low level WebAssembly concepts as we can, as this level of detail will be necessary for languages where we don't have some sort of higher level SDK or library support.

Related Issues

Enables wasmCloud/wasmcloud.com#250

Release Information

N/A

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend merged commit ae05622 into main Jan 3, 2024
46 checks passed
@brooksmtownsend brooksmtownsend deleted the feat/add-keyvalue-logging-examples branch January 3, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants