feat(wash-cli)!: enable websocket port by default #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
connorsmith256
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR sets the NATS server launched with
wash upto always listen on port 4001 for websocket connections, lettingwash uiwork out-of-the-box with a host launched with vanilla options.Related Issues
N/A
Release Information
v0.26.0
Consumer Impact
Users of
wash-cliwill need to be aware that this opens up a websocket port for NATS to listen on that does not have TLS enabled.wash upis not the recommended tool for running in production, and for those use cases it's much better to adhere to our deployment guide to understand how to deploy NATS infrastructure.Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
This worked!