feat(wash-lib): support other build languages #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
changed the title
brooksmtownsend
force-pushed
the
feat/support-other-language
branch
from
d917cf6
to
512aeec
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> PR suggestion Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
feat/support-other-language
branch
from
512aeec
to
f2c9395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR allows
washto support other languages than Rust or TinyGo by using thebuild_commandandbuild_artifactinformation from wasmcloud.toml. The proper usage of these fields is to supply a build command that wash can execute for you, and then the build artifact should be the path to the built Wasm component so wash can then load it to sign the component. For example, a Javascript component will be compilable by wash if you use a wasmcloud.toml like so:I left the language as a completely open String, so users could supply any language other than rust or go if that's what they are using.
Related Issues
Release Information
Patch bump in wash-lib and wash-cli, so whenever we release the next version
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
This worked for my componentize-js demo!