docs(examples): add README for language level #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
docs/examples/per-language-readme
branch
2 times, most recently
from
62116b0
to
9892a38
Compare
vados-cosmonic
force-pushed
the
docs/examples/per-language-readme
branch
2 times, most recently
from
31fcc0f
to
e5801a2
Compare
brooksmtownsend
requested changes
Jan 12, 2024
There was a problem hiding this comment.
A couple requests for markdown formatting.
Only other thing I'd love to have in golang / rust is just a snippet that details that those languages are supported out-of-the-box with wash build, and maybe a experimental note for TypeScript since we don't have that yet
vados-cosmonic
force-pushed
the
docs/examples/per-language-readme
branch
from
e5801a2
to
864ffe1
Compare
While users are perusing examples, it's probably a good idea to add some language-specific information at the root for the given language. As we current have our example structure set up to be `examples/<language>/(actors|...)`, we have a change to add a README at the `examples/<language>` level. This commit adds READMEs for language-level folders under examples. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
docs/examples/per-language-readme
branch
from
864ffe1
to
84bb03e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
While users are perusing examples, it's probably a good idea to add some language-specific information at the root for the given language.
As we current have our example structure set up to be
examples/<language>/(actors|...), we have a change to add a README at theexamples/<language>level.This commit adds READMEs for language-level folders under examples.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification