Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(wash-cli): properly format wash version #1308

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

brooksmtownsend
Copy link
Member

@brooksmtownsend brooksmtownsend commented Jan 11, 2024

Feature or Problem

This PR, hopefully the last of its kind, resolves yet another issue that came from the apt install after publishing. Previously, the github.ref reference would get cut into:

wash-cli-v0.25.0

Which would cause this issue when attempting to install:

Get:1 https://packagecloud.io/wasmCloud/core/ubuntu jammy/main amd64 wash amd64 wash-cli-v0.25.0-packagecloudfix [15.1 MB]
Fetched 15.1 MB in 1s (27.3 MB/s)
dpkg: error processing archive /var/cache/apt/archives/wash_wash-cli-v0.25.0-packagecloudfix_amd64.deb (--unpack):
 parsing file '/var/lib/dpkg/tmp.ci/control' near line 2 package 'wash':
 'Version' field value 'wash-cli-v0.25.0-packagecloudfix': version number does not start with digit
Errors were encountered while processing:
 /var/cache/apt/archives/wash_wash-cli-v0.25.0-packagecloudfix_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

Now, the reference is cut and then trimmed into

0.25.0

Related Issues

#1306
#1303

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

This time I did verify that this actually parses properly into 0.25.0. I can only hope that it's the last issue here as I can't test without having a package in packagecloud

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend requested a review from a team as a code owner January 11, 2024 20:18
@brooksmtownsend brooksmtownsend merged commit a91fa3e into main Jan 11, 2024
46 checks passed
@brooksmtownsend brooksmtownsend deleted the fix/packagecloud-fix-v3 branch January 11, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants