fix(washboard): update lattice service #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lachieh
force-pushed
the
consolidate-react-api-for-latticeservice-1319
branch
from
e2905cc
to
b27adf7
Compare
Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
lachieh
force-pushed
the
consolidate-react-api-for-latticeservice-1319
branch
from
b27adf7
to
d72ecb5
Compare
yordis
reviewed
Jan 13, 2024
connorsmith256
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This is mostly organization and moving toward familiar patterns found in the React ecosystem.
LatticeServiceclass to be initialized outside as an instance (remove singleton pattern)LatticeServiceProvidercomponent anduseLatticeServicehook, implementRelated Issues
Closes #1319
Release Information
nextConsumer Impact
None
Testing
Manual Verification
Confirmed still working with existing
wash up --nats-websocket-port=4001example