refactor(provider-wit-bindgen): use internalized deps for providers #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, providers that used bindgen have had to each add a few dependencies themselves that were required by bindgen: - serde - serde_bytes - async_trait - wasmcloud-provider-sdk Bindgen used these crates as external dependencies (i.e. using a preceeding `::` in the use statements), which meant that crates that used bindgen had to include these dependencies themslves. By refactoring the bidngen crate(s) to contain these dependencies, we can write providers that only require the `wasmcloud_provider_wit_bindgen` top level crate, and use the re-exported dependencies underneath (`wasmcloud_provider_wit_bindgen::deps`) rather than requiring new deps. Unfortunately, for dependencies like `serde` extra care must be taken as it does not rename easily, but other dependencies can mostly be used directly. This commit converts all providers to use internalized dependencies present in `wasmcloud_provider_wit_bindgen`. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat/provider-wit-bindgen/internalize-deps-for-providers
branch
from
03dd003
to
776a032
Compare
brooksmtownsend
approved these changes
Jan 17, 2024
vados-cosmonic
deleted the
feat/provider-wit-bindgen/internalize-deps-for-providers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Up until now, providers that used bindgen have had to each add a few dependencies themselves that were required by bindgen:
Bindgen used these crates as external dependencies (i.e. using a preceeding
::in the use statements), which meant that crates that used bindgen had to include these dependencies themslves.By refactoring the bidngen crate(s) to contain these dependencies, we can write providers that only require the
wasmcloud_provider_wit_bindgentop level crate, and use the re-exported dependenciesunderneath (
wasmcloud_provider_wit_bindgen::deps) rather than requiring new deps.Unfortunately, for dependencies like
serdeextra care must be taken as it does not rename easily, but other dependencies can mostly be used directly.This commit converts all providers to use internalized dependencies present in
wasmcloud_provider_wit_bindgen.Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification