Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated --count argument from wash ctl stop actor calls #1359

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

joonas
Copy link
Contributor

@joonas joonas commented Jan 19, 2024

Feature or Problem

While working on a different change, I noticed the wash-cli common::stop_cmd::test::test_stop_actor_cmd_comprehensive and wash-cli ctl::test::test_ctl_comprehensive tests were failing, so this fixes that.

Failing tests output
    Finished test [unoptimized + debuginfo] target(s) in 0.20s
    Starting 71 tests across 19 binaries
        PASS [   0.012s] wash-cli build::test::test_build_comprehensive
        PASS [   0.012s] wash-cli common::registry_cmd::tests::test_pull_comprehensive
        PASS [   0.013s] wash-cli common::start_cmd::test::test_ctl_comprehensive
        PASS [   0.014s] wash-cli call::test::test_rpc_comprehensive
        FAIL [   0.014s] wash-cli common::stop_cmd::test::test_stop_actor_cmd_comprehensive

--- STDOUT:              wash-cli common::stop_cmd::test::test_stop_actor_cmd_comprehensive ---

running 1 test
test common::stop_cmd::test::test_stop_actor_cmd_comprehensive ... FAILED

failures:

failures:
    common::stop_cmd::test::test_stop_actor_cmd_comprehensive

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 23 filtered out; finished in 0.00s


--- STDERR:              wash-cli common::stop_cmd::test::test_stop_actor_cmd_comprehensive ---
Error: error: unexpected argument '--count' found

  tip: a similar argument exists: '--context'

Usage: ctl stop actor --host-id <HOST_ID> <--ctl-host <CTL_HOST>|--ctl-port <CTL_PORT>|--ctl-jwt <CTL_JWT>|--ctl-seed <CTL_SEED>|--ctl-credsfile <CTL_CREDSFILE>|--js-domain <JS_DOMAIN>|--lattice-prefix <LATTICE_PREFIX>|--timeout-ms <TIMEOUT_MS>|--context <CONTEXT>> <actor-id>

For more information, try '--help'.


   Canceling due to test failure: 9 tests still running
        PASS [   0.014s] wash-cli common::stop_cmd::test::test_stop_host_cmd_comprehensive
        PASS [   0.015s] wash-cli common::registry_cmd::tests::test_push_comprehensive
        PASS [   0.014s] wash-cli ctx::test::test_ctx_comprehensive
        PASS [   0.015s] wash-cli common::stop_cmd::test::test_stop_provider_cmd_comprehensive
        FAIL [   0.018s] wash-cli ctl::test::test_ctl_comprehensive

--- STDOUT:              wash-cli ctl::test::test_ctl_comprehensive ---

running 1 test
test ctl::test::test_ctl_comprehensive ... FAILED

failures:

failures:
    ctl::test::test_ctl_comprehensive

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 23 filtered out; finished in 0.00s


--- STDERR:              wash-cli ctl::test::test_ctl_comprehensive ---
Error: error: unexpected argument '--count' found

  tip: a similar argument exists: '--context'

Usage: ctl stop actor <--ctl-host <CTL_HOST>|--ctl-port <CTL_PORT>|--ctl-jwt <CTL_JWT>|--ctl-seed <CTL_SEED>|--ctl-credsfile <CTL_CREDSFILE>|--js-domain <JS_DOMAIN>|--lattice-prefix <LATTICE_PREFIX>|--timeout-ms <TIMEOUT_MS>|--context <CONTEXT>> <actor-id>

For more information, try '--help'.


        PASS [   0.010s] wash-cli drain::test::test_drain_comprehensive
        PASS [   0.010s] wash-cli keys::tests::test_gen_comprehensive
        PASS [   0.009s] wash-cli keys::tests::test_generate_valid_keypair
        PASS [   0.010s] wash-cli keys::tests::test_generate_basic_test
        PASS [   0.009s] wash-cli keys::tests::test_get_comprehensive
        PASS [   0.009s] wash-cli keys::tests::test_get_basic
        PASS [   0.012s] wash-cli keys::tests::test_generate_all_types
        PASS [   0.011s] wash-cli keys::tests::test_invalid_keytype_input
------------
     Summary [   0.028s] 18/71 tests run: 16 passed, 2 failed, 0 skipped
        FAIL [   0.014s] wash-cli common::stop_cmd::test::test_stop_actor_cmd_comprehensive
        FAIL [   0.018s] wash-cli ctl::test::test_ctl_comprehensive
error: test run failed

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

@joonas joonas requested a review from a team as a code owner January 19, 2024 18:49
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
Copy link
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@connorsmith256 connorsmith256 merged commit 7b85266 into wasmCloud:main Jan 19, 2024
47 checks passed
@joonas joonas deleted the joonas/fix-wash-cli-tests branch January 19, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants