Feat/update event subjects #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
approved these changes
Jan 25, 2024
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
connorsmith256
force-pushed
the
feat/update-event-subjects
branch
from
65b16da
to
f23eb9a
Compare
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This updates the control interface and wash-lib to use the suffixed event subject. Since I modified a public function in the control interface, this is technically a breaking change. However, wash-lib is the only known client using this function
This also fixes an issue where wash would report
Timed out waiting for applicable event, operation may have failed. The latest host emits the scale events, but wash was still looking for the start/stop eventsRelated Issues
#1091
Release Information
Next
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
Manually verified that
wash start actorandwash stop actorreceived the correct events