Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add conditions to rust build code #1386

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

lachieh
Copy link
Contributor

@lachieh lachieh commented Jan 26, 2024

Feature or Problem

After adding a path filter to the wasmcloud job, I noticed that PRs with only changes in the washboard-ui directory were stuck in a pending state because of this issue:

If a workflow is skipped due to branch filtering, path filtering, or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.

Solution

This PR adds a new _file-changes.yml workflow which categorizes changed files into groups, and then surfaces those groups as flags if the contents in those files changed.

Note that this is a temporary solution until a repo re-structure takes place and we can consolidate some of the pipeline steps and change the checks that are required for PRs to merge.

@lachieh lachieh requested a review from a team as a code owner January 26, 2024 00:08
@lachieh lachieh force-pushed the add-conditions-to-rust-build-code branch 11 times, most recently from e89b8ef to 466f79f Compare January 26, 2024 01:35
Signed-off-by: Lachlan Heywood <lachieh@users.noreply.github.com>
@lachieh lachieh merged commit 9d36c97 into main Jan 26, 2024
32 checks passed
@lachieh lachieh deleted the add-conditions-to-rust-build-code branch January 26, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants