chore: Update the default OTLP HTTP port to match the current spec #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas
requested review from
a team,
thomastaylor312 and
connorsmith256
as code owners
connorsmith256
approved these changes
Jan 30, 2024
|
@joonas just need a quick rebase |
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
joonas
force-pushed
the
joonas/update-otel-default-http-port
branch
from
34bf37b
to
dd3b2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
OTEL changed it's default port from 55680/55681 to 4317/4318 for gRPC and HTTP respectively a while back in the spec and in the collector, let's switch over to using the current ports defined in the spec.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification