refactor(host): move label parsing out of host library #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorsmith256
force-pushed
the
refactor/label-parsing
branch
from
ae0a026
to
411f721
Compare
connorsmith256
force-pushed
the
refactor/label-parsing
branch
from
411f721
to
5925c6e
Compare
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
connorsmith256
force-pushed
the
refactor/label-parsing
branch
from
5925c6e
to
1796328
Compare
brooksmtownsend
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This is a simple refactor which moves the parsing logic for labels set via env vars to the main binary, rather than the host library.
Related Issues
Resolves #757
Release Information
Next
Consumer Impact
v0.82.0. I also removed support for the (very old)
HOST_prefix, so this is technically a breaking changeTesting
Unit Test(s)
Acceptance or Integration
Manual Verification