refactor(provider-bindgen): fix import & export semantics #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current semantics are unintuitive -- interfaces "exported" from a provider signifies functionality *provided* to the lattice, and the WIT worlds should reflect that. At present, functionality exposed to the lattice for actors to use is signified by WIT *imports* in the provider worlds. This commit reverses the import and export semantics that were used for WIT contracts in the providers, to make them more intuitive. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
refactor/provider-bindgen/fix-import-and-export-semantics
branch
from
e3ccc7a
to
119bb2c
Compare
brooksmtownsend
approved these changes
Feb 2, 2024
|
@vados-cosmonic can you point to where the logical changes happened here, or split into multiple commits? With this being only one commit, I can't easily tell what was simply split into multiple files, and where the import/export semantics were reversed |
vados-cosmonic
commented
Feb 5, 2024
vados-cosmonic
commented
Feb 5, 2024
vados-cosmonic
commented
Feb 5, 2024
|
Sure @connorsmith256 -- noted some areas that saw change -- most of the rest was splitting up the functionality |
vados-cosmonic
deleted the
refactor/provider-bindgen/fix-import-and-export-semantics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
The current semantics are unintuitive -- interfaces "exported" from a provider signifies functionality provided to the lattice, and the WIT worlds should reflect that.
At present, functionality exposed to the lattice for actors to use is signified by WIT imports in the provider worlds.
This commit reverses the import and export semantics that were used for WIT contracts in the providers, to make them more intuitive.
Resolves #715
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification