fix(wash): windows path to target #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
vados-cosmonic
approved these changes
Feb 9, 2024
brooksmtownsend
approved these changes
Feb 9, 2024
|
Hmm, it looks like a lot of the |
Verbatim paths on Windows are not well supported, e.g. "\\\\?\\C:\\Users..." while technically valid, causes some fs api's like `exists` to fail errantly. The fix is to use a third party lib normpath to normalize the path to the wasm binary. Related issue: rust-lang/cargo#9770 Signed-off-by: Bailey Hayes <behayes2@gmail.com> Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
|
Integration tests caught a bug with what I added. Normalize uses the fs to run the normalization and the file must exist. Tweaked this a bit and re-tested on windows and macos. |
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
Closed
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verbatim paths on Windows are not well supported,
e.g. "\\?\C:\Users..." while technically valid, causes some fs api's like
existsto fail errantly.The fix is to use a third party lib normpath to normalize the path to the wasm
binary.
Related issue: rust-lang/cargo#9770
Fixes #1481
Signed-off-by: Bailey Hayes behayes2@gmail.com