Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wash-lib): update favorites to use components #1503

Merged

Conversation

connorsmith256
Copy link
Contributor

Feature or Problem

This updates the favorites file to use our componentized actor templates

Note that I left the interfaces and providers in there, even though those are smithy based. If we remove them, then e.g. wash new provider will error with:

Failed to generate project

Caused by:
    β›”   templates missing for project type provider

Leaving as do-not-merge until we've released a new version of wash using v0.82 of the host

Related Issues

Resolves #1500

Release Information

Next

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

~/wasmcloud/wasmcloud/target/debug/wash new actor -t hello-world-typescript hello-world-typescript
πŸ”§   Cloning template from repo wasmCloud/wasmCloud subfolder examples/typescript/actors/http-hello-world...
πŸ”§   Using template subfolder examples/typescript/actors/http-hello-world...
πŸ”§   Generating template...
...
Done! New project created /Users/connor/Downloads/hello-world-typescript

Project generated and is located at: /Users/connor/Downloads/hello-world-typescript

@connorsmith256 connorsmith256 added the do-not-merge PR is not ready to be merged label Feb 12, 2024
@connorsmith256 connorsmith256 requested a review from a team as a code owner February 12, 2024 22:48
Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think this should merge so that we can

  1. cut 0.82
  2. cut the next minor version of wash-lib with this in it
  3. update wash-cli to use 0.82 and the new wash-lib
  4. cut wash-cli 0.26

Then componentized examples and wasmCloud 0.82 live together in wash-cli... thoughts?

@brooksmtownsend brooksmtownsend removed the do-not-merge PR is not ready to be merged label Feb 13, 2024
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
@brooksmtownsend brooksmtownsend merged commit 8cdd687 into wasmCloud:main Feb 13, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update our favorites.toml for project generation to point to this repo
2 participants