-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the build problem of wash-lib
with --no-default-features
flag.
#1525
Fix the build problem of wash-lib
with --no-default-features
flag.
#1525
Conversation
Signed-off-by: Cem Eliguzel <cemeliguzel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filing this @rimbi ! I just had a few requests to see if we needed to gate as many modules behind the NATS feature flag. Let me know if my assumption is incorrect.
Otherwise, my only other request is to update the module documentation at the top of lib.rs
to detail the new modules that are behind the nats
feature flag. Looking forward to it!
Hi @brooksmtownsend . What do you mean with |
Hey @rimbi all I mean is at the top of wash-lib's
I just wanted to add the other modules to the list by the |
Signed-off-by: Cem Eliguzel <cemeliguzel@gmail.com>
035a51e
to
8fbd806
Compare
done! 👍 |
@brooksmtownsend is the failing test a glitch, or? |
Feature or Problem
Fixes the build problem of
wash-lib
with--no-default-features
flag.Related Issues
Fixes issue #862
Release Information
N/A
Consumer Impact
N/A
Testing
build succeeds in
crates/wash-lib
:cargo build --no-default-features
Unit Test(s)
N/A
Acceptance or Integration
N/A
Manual Verification
N/A