fix(provider-wit-bindgen): argument bundling & type resolution #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two issues with provider bindgen: - Types replaced as part of structs were using their full qualified paths, depsite types being lifted to the top level (with structs), not needing it. - Invocation arguments for `LatticeMethod`s that were recorded were not being saved when processing structs. This comes up when exporting a function that needed it's arguments bundled into a struct Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
ricochet
approved these changes
Feb 27, 2024
vados-cosmonic
deleted the
fix(provider-wit-bindgen)=misimported-type
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This commit fixes two issues with provider bindgen:
Types replaced as part of structs were using their full qualified paths, depsite types being lifted to the top level (with structs), not needing it.
Invocation arguments for
LatticeMethods that were recorded were not being saved when processing structs. This comes up when exporting a function that needed it's arguments bundled into a structRelated Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification