feat(metrics) add invocation and error counts for actor invocations #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protochron
requested review from
a team,
thomastaylor312 and
connorsmith256
as code owners
protochron
force-pushed
the
additional_actor_metrics
branch
4 times, most recently
from
c0b7c62
to
aef79c7
Compare
Add two new metrics for actors:
* the count of the number of invocations (`wasmcloud_host.actor.invocations`)
* the count of errors (`wasmcloud_host.actor.invocation.errors`)
This also adds a bunch of new attributes to the existing actor metrics so that they make sense in an environment with multiple hosts. Specifically this adds:
* the lattice ID
* the host ID
* provider information if a provider invoked the actor: ** the contract ID
** the provider ID
** the name of the linkdef
For actor to actor calls, instead of having the provider metadata it instead has the public key of the invoking actor.
An example of what this looks like as an exported Prometheus metric:
```
wasmcloud_host_actor_invocations_total{actor_ref="wasmcloud.azurecr.io/echo:0.3.8", caller_provider_contract_id="wasmcloud:httpserver", caller_provider_id="VAG3QITQQ2ODAOWB5TTQSDJ53XK3SHBEIFNK4AYJ5RKAX2UNSCAPHA5M", caller_provider_link_name="default", host="ND7L3RZ6NLYJGN25E6DKYS665ITWXAPXZXGZXLCUQEDDU65RB5TVUHEN", job="wasmcloud-host", lattice="default", operation="HttpServer.HandleRequest"}
```
Provider metrics will likely need to wait until the wRPC work is finished.
Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
protochron
force-pushed
the
additional_actor_metrics
branch
from
aef79c7
to
a8674e5
Compare
brooksmtownsend
approved these changes
Feb 29, 2024
|
Tried to merge but it looks like we need an approval from @thomastaylor312 |
|
@thomastaylor312 bump |
thomastaylor312
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Add two new metrics for actors:
wasmcloud_host.actor.invocations)wasmcloud_host.actor.errors)This also adds a bunch of new attributes to the existing actor metrics so that they make sense in an environment with multiple hosts. Specifically this adds:
For actor to actor calls, instead of having the provider metadata it instead has the public key of the invoking actor.
An example of what this looks like as an exported Prometheus metric:
Provider metrics will likely need to wait until the wRPC work is finished.
Related Issues
A start on adding some of the additional metrics highlighted in #664.
Release Information
Consumer Impact
Testing
Tested locally with an OTEL collector relaying metrics to Prometheus.
Unit Test(s)
Acceptance or Integration
Manual Verification