fix(provider-wit-bindgen): type aliasing for nested types #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
fix(provider-wit-bindgen)=fix-top-level-type-hoisting
branch
2 times, most recently
from
30370be
to
1bfa996
Compare
When using a type alias in WIT (ex. `type str-list = vec<string>`), if that type is inside an interface and used from another interface, there is an extra alias made to it. Since bindgen sees *both* the "real" alias (in Rust `type StrList = Vec<String>`) and the local binding level alias (in Rust `type StrList = super::some::iface::StrList`), we need to make sure that the "real" alias is the one that is hoisted to the top. This commit adds some checks to ensure that the alias that is *not* a reference is sure to be hoisted to the top (all generated code uses `T`, not `super::some::iface::T`). This is a a shortcut to avoid building a type reference graph. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
fix(provider-wit-bindgen)=fix-top-level-type-hoisting
branch
from
1bfa996
to
8cc9202
Compare
brooksmtownsend
approved these changes
Mar 4, 2024
vados-cosmonic
deleted the
fix(provider-wit-bindgen)=fix-top-level-type-hoisting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
When using a type alias in WIT (ex.
type str-list = vec<string>), if that type is inside an interface and used from another interface, there is an extra alias made to it.Since bindgen sees both the "real" alias (in Rust
type StrList = Vec<String>) and the local binding level alias (in Rusttype StrList = super::some::iface::StrList), we need to make sure that the "real" alias is the one that is hoisted to the top.This commit adds some checks to ensure that the alias that is not a reference is sure to be hoisted to the top (all generated code uses
T, notsuper::some::iface::T). This is a a shortcut to avoid building a type reference graph.Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification