chore: prefix NATS_PORT and NATS_URL with WASMCLOUD #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protochron
force-pushed
the
nats_env_var_rename
branch
from
c8a2c91
to
413b28f
Compare
brooksmtownsend
requested changes
Mar 7, 2024
This adds a `WASMCLOUD` prefix to both the `NATS_PORT` and `NATS_URL` env vars, since there are potentially conficts with those variables in other systems. Specifically this would play badly deploying in Kubernetes with a service named `nats` running in the same namespace, since a `NATS_PORT` env var is automatically injected in that case which stops the wasmcloud binary from starting. It is also a good practice to have all of our environment variables using the same prefix. This is a breaking change to wasmCloud CLI args for the host. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
protochron
force-pushed
the
nats_env_var_rename
branch
from
413b28f
to
e8cefd3
Compare
brooksmtownsend
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This adds a
WASMCLOUDprefix to both theNATS_PORTandNATS_URLenv vars, since there are potentially conficts with those variables in other systems. Specifically this would play badly deploying in Kubernetes with a service namednatsrunning in the same namespace, since aNATS_PORTenv var is automatically injected in that case which stops the wasmcloud binary from starting. It is also a good practice to have all of our environment variables using the same prefix.This is a breaking change to wasmCloud CLI args for the host.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification